Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1409073002: Make IdleTimeEstimator ignore nested tasks (Closed)

Created:
5 years, 2 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 2 months ago
Reviewers:
Sami
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make IdleTimeEstimator ignore nested tasks Unfortunately you can run a modal dialog inside a RAF so nesting of compositor tasks is possible. Like other places in the scheduler we ignore nested tasks for timing computations. BUG=543894 Committed: https://crrev.com/f57538cc64cdc6b860c588ff17bb18508d77bc68 Cr-Commit-Position: refs/heads/master@{#354505}

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 2

Patch Set 3 : Added a DCHECK #

Patch Set 4 : Needs to be DCHECK_GE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M components/scheduler/renderer/idle_time_estimator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/renderer/idle_time_estimator.cc View 1 2 3 3 chunks +9 lines, -4 lines 0 comments Download
M components/scheduler/renderer/idle_time_estimator_unittest.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
alex clarke (OOO till 29th)
PTAL
5 years, 2 months ago (2015-10-16 10:39:33 UTC) #2
Sami
lgtm with a nit. https://codereview.chromium.org/1409073002/diff/20001/components/scheduler/renderer/idle_time_estimator.cc File components/scheduler/renderer/idle_time_estimator.cc (right): https://codereview.chromium.org/1409073002/diff/20001/components/scheduler/renderer/idle_time_estimator.cc#newcode63 components/scheduler/renderer/idle_time_estimator.cc:63: nesting_level_--; nit: DCHECK_GT(nesting_level_, 0);
5 years, 2 months ago (2015-10-16 10:52:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409073002/40001
5 years, 2 months ago (2015-10-16 10:54:41 UTC) #6
alex clarke (OOO till 29th)
https://codereview.chromium.org/1409073002/diff/20001/components/scheduler/renderer/idle_time_estimator.cc File components/scheduler/renderer/idle_time_estimator.cc (right): https://codereview.chromium.org/1409073002/diff/20001/components/scheduler/renderer/idle_time_estimator.cc#newcode63 components/scheduler/renderer/idle_time_estimator.cc:63: nesting_level_--; On 2015/10/16 10:52:11, Sami wrote: > nit: DCHECK_GT(nesting_level_, ...
5 years, 2 months ago (2015-10-16 10:54:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/127500)
5 years, 2 months ago (2015-10-16 11:28:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409073002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409073002/60001
5 years, 2 months ago (2015-10-16 11:48:04 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-16 13:29:25 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 13:30:17 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f57538cc64cdc6b860c588ff17bb18508d77bc68
Cr-Commit-Position: refs/heads/master@{#354505}

Powered by Google App Engine
This is Rietveld 408576698