Aura on Android: Stub implementation of UsbPrinterManifestHandler.

Aura on Android: Stub implementation of UsbPrinterManifestHandler.

BUG=507792
Committed: https://crrev.com/1a1d36d627f1235fafd3cb95b2e1fdd0656a6525
Cr-Commit-Position: refs/heads/master@{#357597}

[Hadi, 2015-11-02 21:57:50]

Description was changed from

==========
Aura on Android: Stub implementation of UsbPrinterManifestHandler.

BUG=
==========

to

==========
Aura on Android: Stub implementation of UsbPrinterManifestHandler.

BUG=507792
==========

[Hadi, 2015-11-02 21:59:47]

moshayedi@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[Hadi, 2015-11-02 21:59:48]

As was suggested in https://codereview.chromium.org/1416513006/, this patch
implements a stub implementation of UsbPrinterManifestHandler.

[mfomitchev, 2015-11-03 15:23:29]

https://codereview.chromium.org/1409033007/diff/1/extensions/common/BUILD.gn
File extensions/common/BUILD.gn (right):

https://codereview.chromium.org/1409033007/diff/1/extensions/common/BUILD.gn#...
extensions/common/BUILD.gn:75: deps += [ "//device/usb" ]
Remove this conditionally rather than adding it conditionally.

https://codereview.chromium.org/1409033007/diff/1/extensions/common/BUILD.gn#...
extensions/common/BUILD.gn:83: [
"api/printer_provider/usb_printer_manifest_handler_android.cc" ]
Add this in gypi, then you won't need a special rule for it.

[Hadi, 2015-11-03 16:31:53]

https://codereview.chromium.org/1409033007/diff/1/extensions/common/BUILD.gn
File extensions/common/BUILD.gn (right):

https://codereview.chromium.org/1409033007/diff/1/extensions/common/BUILD.gn#...
extensions/common/BUILD.gn:75: deps += [ "//device/usb" ]
On 2015/11/03 15:23:29, mfomitchev wrote:
> Remove this conditionally rather than adding it conditionally. 

Done.

https://codereview.chromium.org/1409033007/diff/1/extensions/common/BUILD.gn#...
extensions/common/BUILD.gn:83: [
"api/printer_provider/usb_printer_manifest_handler_android.cc" ]
On 2015/11/03 15:23:29, mfomitchev wrote:
> Add this in gypi, then you won't need a special rule for it.

Done.

[mfomitchev, 2015-11-03 16:35:10]

LGTM

[Hadi, 2015-11-03 16:50:33]

moshayedi@chromium.org changed reviewers:
+ asargent@chromium.org

[Hadi, 2015-11-03 16:50:34]

asargent@ can you please provide OWNER review for this CL?

[asargent_no_longer_on_chrome, 2015-11-03 17:56:57]

lgtm

[Hadi, 2015-11-03 19:23:45]

The CQ bit was checked by moshayedi@chromium.org

[commit-bot: I haz the power, 2015-11-03 19:25:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409033007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409033007/40001

[commit-bot: I haz the power, 2015-11-03 20:04:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-03 20:05:36]

Patchset 3 (id:??) landed as
https://crrev.com/1a1d36d627f1235fafd3cb95b2e1fdd0656a6525
Cr-Commit-Position: refs/heads/master@{#357597}