Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: extensions/common/api/printer_provider/usb_printer_manifest_handler_android.cc

Issue 1409033007: Aura on Android: Stub implementation of UsbPrinterManifestHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a problem with the gypi file. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/BUILD.gn ('k') | extensions/extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/printer_provider/usb_printer_manifest_handler_android.cc
diff --git a/extensions/common/api/printer_provider/usb_printer_manifest_handler.cc b/extensions/common/api/printer_provider/usb_printer_manifest_handler_android.cc
similarity index 55%
copy from extensions/common/api/printer_provider/usb_printer_manifest_handler.cc
copy to extensions/common/api/printer_provider/usb_printer_manifest_handler_android.cc
index e356050b7e116491badda09cbf2b7022029ed061..88861c4b74141d565c6d684dfe98c8297cff2f78 100644
--- a/extensions/common/api/printer_provider/usb_printer_manifest_handler.cc
+++ b/extensions/common/api/printer_provider/usb_printer_manifest_handler_android.cc
@@ -4,9 +4,7 @@
#include "extensions/common/api/printer_provider/usb_printer_manifest_handler.h"
-#include "extensions/common/api/printer_provider/usb_printer_manifest_data.h"
#include "extensions/common/extension.h"
-#include "extensions/common/manifest_constants.h"
namespace extensions {
@@ -18,20 +16,11 @@ UsbPrinterManifestHandler::~UsbPrinterManifestHandler() {
bool UsbPrinterManifestHandler::Parse(Extension* extension,
base::string16* error) {
- const base::Value* usb_printers = nullptr;
- CHECK(extension->manifest()->Get(manifest_keys::kUsbPrinters, &usb_printers));
- scoped_ptr<UsbPrinterManifestData> data =
- UsbPrinterManifestData::FromValue(*usb_printers, error);
- if (!data) {
- return false;
- }
-
- extension->SetManifestData(manifest_keys::kUsbPrinters, data.release());
- return true;
+ return false;
}
const std::vector<std::string> UsbPrinterManifestHandler::Keys() const {
- return SingleKey(manifest_keys::kUsbPrinters);
+ return std::vector<std::string>();
}
} // namespace extensions
« no previous file with comments | « extensions/common/BUILD.gn ('k') | extensions/extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698