Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1409023005: Clean up certificate viewer in RTL mode. (Closed)

Created:
5 years, 1 month ago by newt (away)
Modified:
5 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up certificate viewer in RTL mode. This makes two improvements to the certificate viewer in RTL mode: 1. All text is now right-aligned, even English text, for consistency and easy scanning. 2. The certificate name no longer overlaps the dropdown arrow. BUG=548156 Committed: https://crrev.com/1c62327db90915de73cecf256f06cffc567a0be1 Cr-Commit-Position: refs/heads/master@{#356464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/CertificateViewer.java View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
newt (away)
PTAL
5 years, 1 month ago (2015-10-27 23:55:00 UTC) #2
newt (away)
Before/after screenshots are on the bug: https://code.google.com/p/chromium/issues/detail?id=548156#c4
5 years, 1 month ago (2015-10-27 23:55:39 UTC) #3
Ted C
lgtm
5 years, 1 month ago (2015-10-28 00:02:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409023005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409023005/1
5 years, 1 month ago (2015-10-28 00:05:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 00:55:15 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 00:56:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c62327db90915de73cecf256f06cffc567a0be1
Cr-Commit-Position: refs/heads/master@{#356464}

Powered by Google App Engine
This is Rietveld 408576698