Clean up certificate viewer in RTL mode.

chrome/android/java/src/org/chromium/chrome/browser/CertificateViewer.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.app.Dialog;
 import android.content.Context;
 import android.graphics.Typeface;
 import android.net.http.SslCertificate;
@@ skipping 52 matching lines @@
     }
 
     // Show information about an array of DER-encoded data representing a X509 certificate chain.
     // A spinner will be displayed allowing the user to select which certificate to display.
     private void showCertificateChain(byte[][] derData) {
         for (int i = 0; i < derData.length; i++) {
             addCertificate(derData[i]);
         }
         ArrayAdapter<String> arrayAdapter = new ArrayAdapter<String>(mContext,
                 android.R.layout.simple_spinner_item,
-                mTitles);
+                mTitles) {
+            @Override
+            public View getView(int position, View convertView, ViewGroup parent) {
+                TextView view = (TextView) super.getView(position, convertView, parent);
+                // Add extra padding on the end side to avoid overlapping the dropdown arrow.
+                ApiCompatibilityUtils.setPaddingRelative(view, mPadding, mPadding, mPadding * 2,
+                        mPadding);
+                return view;
+            }
+        };
         arrayAdapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
 
         LinearLayout dialogContainer = new LinearLayout(mContext);
         dialogContainer.setOrientation(LinearLayout.VERTICAL);
 
         TextView title = new TextView(mContext);
         title.setText(R.string.certtitle);
+        ApiCompatibilityUtils.setTextAlignment(title, View.TEXT_ALIGNMENT_VIEW_START);
         ApiCompatibilityUtils.setTextAppearance(title, android.R.style.TextAppearance_Large);
         title.setTypeface(title.getTypeface(), Typeface.BOLD);
         title.setPadding(mPadding, mPadding, mPadding, mPadding / 2);
         dialogContainer.addView(title);
 
         Spinner spinner = new Spinner(mContext);
+        ApiCompatibilityUtils.setTextAlignment(spinner, View.TEXT_ALIGNMENT_VIEW_START);
         spinner.setAdapter(arrayAdapter);
         spinner.setOnItemSelectedListener(this);
         spinner.setDropDownWidth(ViewGroup.LayoutParams.MATCH_PARENT);
-        spinner.setPadding(0, 0, 0, mPadding);
+        // Remove padding so that dropdown has same width as the spinner.
+        spinner.setPadding(0, 0, 0, 0);
         dialogContainer.addView(spinner);
 
         LinearLayout certContainer = new LinearLayout(mContext);
         certContainer.setOrientation(LinearLayout.VERTICAL);
         for (int i = 0; i < mViews.size(); ++i) {
             LinearLayout certificateView = mViews.get(i);
             if (i != 0) {
                 certificateView.setVisibility(LinearLayout.GONE);
             }
             certContainer.addView(certificateView);
@@ skipping 77 matching lines @@
 
     private void addItem(LinearLayout certificateView, String label, String value) {
         if (value.isEmpty()) return;
 
         addLabel(certificateView, label);
         addValue(certificateView, value);
     }
 
     private TextView addLabel(LinearLayout certificateView, String label) {
         TextView t = new TextView(mContext);
+        ApiCompatibilityUtils.setTextAlignment(t, View.TEXT_ALIGNMENT_VIEW_START);
         t.setPadding(mPadding, mPadding / 2, mPadding, 0);
         t.setText(label);
         t.setTypeface(Typeface.defaultFromStyle(Typeface.BOLD));
         t.setTextColor(ApiCompatibilityUtils.getColor(mContext.getResources(),
                 R.color.connection_info_popup_text));
         certificateView.addView(t);
         return t;
     }
 
     private void addValue(LinearLayout certificateView, String value) {
         TextView t = new TextView(mContext);
+        ApiCompatibilityUtils.setTextAlignment(t, View.TEXT_ALIGNMENT_VIEW_START);
         t.setText(value);
         t.setPadding(mPadding, 0, mPadding, mPadding / 2);
         t.setTextColor(ApiCompatibilityUtils.getColor(mContext.getResources(),
                 R.color.connection_info_popup_text));
         certificateView.addView(t);
     }
 
     private static String formatBytes(byte[] bytes, char separator) {
         StringBuilder sb = new StringBuilder();
         for (int i = 0; i < bytes.length; i++) {
@@ skipping 33 matching lines @@
     private static native String nativeGetCertInfoSerialNumberText();
     private static native String nativeGetCertInfoOrganizationUnitText();
     private static native String nativeGetCertIssuedByText();
     private static native String nativeGetCertValidityText();
     private static native String nativeGetCertIssuedOnText();
     private static native String nativeGetCertExpiresOnText();
     private static native String nativeGetCertFingerprintsText();
     private static native String nativeGetCertSHA256FingerprintText();
     private static native String nativeGetCertSHA1FingerprintText();
 }