Modify the headers in src/ to forward to url/*.h

Modify the headers in src/ to forward to url/*.h

BUG=chromium:229660
TEST=googleurl_unittests on chromium repo.
R=brettw@chromium.org
Signed-off-by: Thiago Farina <tfarina@chromium.org>;

[tfarina, 2013-04-11 22:42:50]

Hi Brett, could you review this to me?

Note: This won't link when rolling the deps unless we have this:
https://codereview.chromium.org/14202003/

Since both depend on each other, they can't be landed separately.

We need a way to inline "virtual void Resize()" again in url_canon_stdstring.h
in order to get this working again.

Ideas?

[brettw, 2013-04-11 22:47:07]

I don't think we should have a problem with Resize() unless I'm missing
something. I believe the DEPS roll that would pull this version of googleurl in
would also fix up all .gyp files to reference the new url/url.gyp file.
Everything should be consistent when we do that.

[tfarina, 2013-04-11 22:50:00]

On Thu, Apr 11, 2013 at 7:47 PM,  <brettw@chromium.org> wrote:
> I don't think we should have a problem with Resize() unless I'm missing
> something. I believe the DEPS roll that would pull this version of googleurl
> in
> would also fix up all .gyp files to reference the new url/url.gyp file.
Ah, ok, at the same time I roll the version in the DEPS file, I'll
also change the references from build/temp_gyp/googleurl.gyp to
url/url.gyp?

-- 
Thiago

[brettw, 2013-04-11 22:54:19]

yes, otherwise you're using the new headers and the old .cc's which is a recipe
for disaster (which you're finding with the Resize() issue).

[tfarina, 2013-04-11 23:00:35]

On 2013/04/11 22:54:19, brettw wrote:
> yes, otherwise you're using the new headers and the old .cc's which is a
recipe
> for disaster (which you're finding with the Resize() issue).

OK, makes sense. I'm closing https://codereview.chromium.org/14202003/ so.

As a test I changed rlz.gyp to include url/url.gyp:url and moved the "original"
googleurl/ to another place and put a new googleurl/ with my changes and
compiled rlz_unittests. That seems to work fine.

So looks like we are fine to go now.

I'll just need to update the references of googleurl.gyp to url.gyp in the same
patch I change the DEPS file.

[brettw, 2013-04-11 23:09:18]

Committed as googleurl@185.

Blink may also pull googleurl so keep an eye out for problems there.

[tfarina, 2013-04-11 23:18:16]

On 2013/04/11 23:09:18, brettw wrote:
> Committed as googleurl@185.
> 
> Blink may also pull googleurl so keep an eye out for problems there.

Updating Blink/third_party/WebKit will be a source of complication.

As far as I can see Blink/WebKit doesn't have its own DEPS file to pull from
google-url, instead it makes an assumption that googleurl.gyp will be there in
the Chromium repo.

There are a bunch references to <(DEPTH)/build/temp_gyp/googleurl.gyp:googleurl
in the Blink tree.

[brettw, 2013-04-11 23:20:19]

I suppose you can make the one in temp_gyp refer to the files in the new
location in the first patch. Then update blink to use src/url/url.gyp, then
delete the temp one. Lots of steps!

[tfarina, 2013-04-11 23:25:54]

On 2013/04/11 23:20:19, brettw wrote:
> I suppose you can make the one in temp_gyp refer to the files in the new
> location in the first patch.
Yeah, I think that will be easier to do rather than what we tried here:
https://codereview.chromium.org/12073003/
;)

> Then update blink to use src/url/url.gyp, then
> delete the temp one. Lots of steps!
We will get there :)