Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 12073003: Make build/temp_gyp/googleurl a 'none' target that depends on the 'real' src/googleurl/googleurl.gyp (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin (slow to review)
Visibility:
Public.

Description

Make build/temp_gyp/googleurl a 'none' target that depends on the 'real' src/googleurl/googleurl.gyp This is the first step to change all the references from build/temp_gyp/ to the new location in src/googleurl/ R=brettw@chromium.org,rsleevi@chromium.org TBR=darin@chromium.org # for gyp change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179081

Patch Set 1 #

Patch Set 2 : fix todo #

Total comments: 1

Patch Set 3 : rm googleurl_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -118 lines) Patch
M build/all.gyp View 1 2 13 chunks +18 lines, -18 lines 0 comments Download
M build/temp_gyp/googleurl.gyp View 1 2 2 chunks +6 lines, -93 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Hi, you guys might be too busy to review this, so please feel free to ...
7 years, 11 months ago (2013-01-25 20:43:38 UTC) #1
brettw
I'm not as much of a ninja expert as Ryan so I'll defer to him.
7 years, 11 months ago (2013-01-25 21:59:43 UTC) #2
Ryan Sleevi
https://codereview.chromium.org/12073003/diff/2001/build/temp_gyp/googleurl.gyp File build/temp_gyp/googleurl.gyp (right): https://codereview.chromium.org/12073003/diff/2001/build/temp_gyp/googleurl.gyp#newcode22 build/temp_gyp/googleurl.gyp:22: 'target_name': 'googleurl_unittests', Are there any targets in third-party code ...
7 years, 11 months ago (2013-01-25 22:02:54 UTC) #3
tfarina
On 2013/01/25 22:02:54, Ryan Sleevi wrote: > https://codereview.chromium.org/12073003/diff/2001/build/temp_gyp/googleurl.gyp#newcode22 > build/temp_gyp/googleurl.gyp:22: 'target_name': 'googleurl_unittests', > Are there ...
7 years, 11 months ago (2013-01-25 23:21:15 UTC) #4
Ryan Sleevi
lgtm
7 years, 11 months ago (2013-01-25 23:40:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12073003/10001
7 years, 11 months ago (2013-01-26 18:40:32 UTC) #6
commit-bot: I haz the power
Change committed as 179081
7 years, 11 months ago (2013-01-27 05:51:07 UTC) #7
James Cook
7 years, 11 months ago (2013-01-27 06:53:41 UTC) #8
Message was sent while issue was closed.
On 2013/01/27 05:51:07, I haz the power (commit-bot) wrote:
> Change committed as 179081

I had to revert this as it broke Win Builder (dbg) - see
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Builder%20...

Powered by Google App Engine
This is Rietveld 408576698