Using RunLoop rather than the deprecated, older loop running methods.

Using RunLoop rather than the deprecated, older loop running methods.

BUG=

Committed: https://crrev.com/72d4f7cba97b48465f4c5c93ceab7f8d81dc4e3e
Cr-Commit-Position: refs/heads/master@{#355080}

[Łukasz Anforowicz, 2015-10-19 19:33:59]

lukasza@chromium.org changed reviewers:
+ rdsmith@chromium.org

[Łukasz Anforowicz, 2015-10-19 19:34:00]

Randy, could you please take a look?

[Randy Smith (Not in Mondays), 2015-10-19 19:37:02]

LGTM; thanks for doing this.

https://codereview.chromium.org/1408993003/diff/1/chrome/browser/download/sav...
File chrome/browser/download/save_page_browsertest.cc (right):

https://codereview.chromium.org/1408993003/diff/1/chrome/browser/download/sav...
chrome/browser/download/save_page_browsertest.cc:73: quit_waiting_callback_(),
I think member variables normally are default constructed if you don't mention
them in the constructor list, so I think you can just remove this line.

https://codereview.chromium.org/1408993003/diff/1/chrome/browser/download/sav...
chrome/browser/download/save_page_browsertest.cc:118: quit_waiting_callback_(),
Ditto (can remove line).

https://codereview.chromium.org/1408993003/diff/1/chrome/browser/download/sav...
chrome/browser/download/save_page_browsertest.cc:195: :
quit_waiting_callback_(), manager_(manager) {
Ditto.

[Łukasz Anforowicz, 2015-10-19 22:04:39]

https://codereview.chromium.org/1408993003/diff/1/chrome/browser/download/sav...
File chrome/browser/download/save_page_browsertest.cc (right):

https://codereview.chromium.org/1408993003/diff/1/chrome/browser/download/sav...
chrome/browser/download/save_page_browsertest.cc:73: quit_waiting_callback_(),
On 2015/10/19 19:37:02, rdsmith wrote:
> I think member variables normally are default constructed if you don't mention
> them in the constructor list, so I think you can just remove this line.

Done.

In the original patchset/snapshot, I left this line to indicate to the reader,
that we didn't simply forget to initialize this member (i.e. that we
really/explicitly are happy with the default initialization).  OTOH, I guess
consistency triumphs this (and I think elsewhere in Chromium default
initialization is not explicitly mentioned on initializer lists).

https://codereview.chromium.org/1408993003/diff/1/chrome/browser/download/sav...
chrome/browser/download/save_page_browsertest.cc:118: quit_waiting_callback_(),
On 2015/10/19 19:37:01, rdsmith wrote:
> Ditto (can remove line).

Done.

https://codereview.chromium.org/1408993003/diff/1/chrome/browser/download/sav...
chrome/browser/download/save_page_browsertest.cc:195: :
quit_waiting_callback_(), manager_(manager) {
On 2015/10/19 19:37:02, rdsmith wrote:
> Ditto.

Done.

[Łukasz Anforowicz, 2015-10-20 16:11:56]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2015-10-20 16:11:57]

The patchset sent to the CQ was uploaded after l-g-t-m from rdsmith@chromium.org
Link to the patchset: https://codereview.chromium.org/1408993003/#ps40001
(title: "Rebasing...")

[commit-bot: I haz the power, 2015-10-20 16:12:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408993003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408993003/40001

[commit-bot: I haz the power, 2015-10-20 16:51:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-20 16:52:08]

Patchset 3 (id:??) landed as
https://crrev.com/72d4f7cba97b48465f4c5c93ceab7f8d81dc4e3e
Cr-Commit-Position: refs/heads/master@{#355080}