Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Issue 1408953005: Revert of Avoid Copying damage rect when using Overlays (Closed)

Created:
5 years, 1 month ago by ccameron
Modified:
5 years, 1 month ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Avoid Copying damage rect when using Overlays (patchset #13 id:240001 of https://codereview.chromium.org/1330563004/ ) Reason for revert: This broke YouTube on Mac, in particular the sandwich overlay strategy. BUG=549350 Original issue's description: > Avoid Copying damage rect when using Overlays > > When using Overlays, the damage rect can be completely covered by > the layer being composited by Overlay. We still copy damage rect > on to the current surface(Primary frame buffer) in BufferQueue. This > should be un-necessary. > > BUG=370522, 548452 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/2904998edff0cfcaab43eeb3b1db013d6169bd17 > Cr-Commit-Position: refs/heads/master@{#356352} > > Committed: https://crrev.com/5ee13b006abdf74d0f6b3fbdde2d936c00ad97e7 > Cr-Commit-Position: refs/heads/master@{#356570} TBR=alexst@chromium.org,achaulk@chromium.org,danakj@chromium.org,piman@chromium.org,kalyan.kondapally@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=370522, 548452 Committed: https://crrev.com/f6a13431381bb070228b5af79e6fd537251c647b Cr-Commit-Position: refs/heads/master@{#357224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -135 lines) Patch
M cc/output/direct_renderer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/overlay_candidate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/overlay_candidate.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/output/overlay_processor.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/overlay_processor.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M cc/output/overlay_unittest.cc View 38 chunks +82 lines, -105 lines 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
Created Revert of Avoid Copying damage rect when using Overlays
5 years, 1 month ago (2015-10-30 23:30:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408953005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408953005/1
5 years, 1 month ago (2015-10-30 23:33:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 23:35:41 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 23:36:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6a13431381bb070228b5af79e6fd537251c647b
Cr-Commit-Position: refs/heads/master@{#357224}

Powered by Google App Engine
This is Rietveld 408576698