cc/output/overlay_candidate.cc - Issue 1408953005: Revert of Avoid Copying damage rect when using Overlays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/overlay_candidate.cc

Issue 1408953005: Revert of Avoid Copying damage rect when using Overlays (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/overlay_candidate.cc

diff --git a/cc/output/overlay_candidate.cc b/cc/output/overlay_candidate.cc

index 5931e7da82815f808b9310dac68a3683f7fffc24..658f15382bc68a9ff6d67f7512954d6e73534e3f 100644

--- a/cc/output/overlay_candidate.cc

+++ b/cc/output/overlay_candidate.cc

@@ -175,7 +175,6 @@

use_output_surface_for_resource(false),

resource_id(0),

plane_z_order(0),

- needs_blending(false),

overlay_handled(false) {}

OverlayCandidate::~OverlayCandidate() {}

@@ -197,8 +196,6 @@

candidate->format = RGBA_8888;

candidate->clip_rect = quad->shared_quad_state->clip_rect;

candidate->is_clipped = quad->shared_quad_state->is_clipped;

- candidate->needs_blending =

- quad->shared_quad_state->opacity < 1.0f || quad->needs_blending;

switch (quad->material) {

case DrawQuad::TEXTURE_CONTENT:

« no previous file with comments | « cc/output/overlay_candidate.h ('k') | cc/output/overlay_processor.h » ('j') | no next file with comments »