content/browser/service_worker/service_worker_browsertest.cc - Issue 140893002: Adding slightly clearer separation between SW and EmbeddedWorker (still incomplete)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 140893002: Adding slightly clearer separation between SW and EmbeddedWorker (still incomplete) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_registry.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index e4894bbbcc3e0a25927f1426fe2b5aa715d2fa13..ff11946d4e2f8a6160621efed1fa4213d2bb9be7 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -112,6 +112,7 @@ class ServiceWorkerBrowserTest : public ContentBrowserTest,

last_worker_status_ = worker_->status();

BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done_closure_);

}

+ virtual void OnMessageReceived(const IPC::Message& message) OVERRIDE {}

alecflett 2014/01/16 17:50:08 Maybe add a comment indicating that it's safe to i

kinuko 2014/01/17 03:18:54 Done. Added NOTREACHED()

ServiceWorkerProviderHost* GetRegisteredProviderHost() {

// Assumes only one provider host is registered at this point.