Adding slightly clearer separation between SW and EmbeddedWorker (still incomplete)

content/browser/service_worker/service_worker_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/run_loop.h"
 #include "content/browser/service_worker/embedded_worker_instance.h"
@@ skipping 94 matching lines @@
     ASSERT_FALSE(done_closure_.is_null());
     last_worker_status_ = worker_->status();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done_closure_);
   }
   virtual void OnStopped() OVERRIDE {
     ASSERT_TRUE(worker_ != NULL);
     ASSERT_FALSE(done_closure_.is_null());
     last_worker_status_ = worker_->status();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done_closure_);
   }
+  virtual void OnMessageReceived(const IPC::Message& message) OVERRIDE {}

[alecflett, 2014/01/16 17:50:08]

Maybe add a comment indicating that it's safe to ignore any messages, since this
is about startup/shutdown?

(Thought I think personally I'd actually put a NOTREACHED() in here so when in
the future we fire stuff like OnInstallComplete, we can decide if it's important
to check for those specific messages after startup or before shutdown)

[kinuko, 2014/01/17 03:18:54]

Done. Added NOTREACHED()

 
   ServiceWorkerProviderHost* GetRegisteredProviderHost() {
     // Assumes only one provider host is registered at this point.
     std::vector<ServiceWorkerProviderHost*> providers;
     wrapper_->context()->GetAllProviderHosts(&providers);
     DCHECK_EQ(1U, providers.size());
     return providers[0];
   }
 
   scoped_refptr<ServiceWorkerContextWrapper> wrapper_;
@@ skipping 25 matching lines @@
   done_closure_ = stop_run_loop.QuitClosure();
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&self::StopEmbeddedWorkerOnIOThread, this));
   stop_run_loop.Run();
 
   ASSERT_EQ(EmbeddedWorkerInstance::STOPPED, last_worker_status_);
 }
 
 }  // namespace content