Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1408923005: Add IsMutatorThread to the Thread class and use it instead of MutatorThreadIsCurrentThread (Closed)

Created:
5 years, 1 month ago by siva
Modified:
5 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add IsMutatorThread to the Thread class and use it instead of MutatorThreadIsCurrentThread Committed: https://github.com/dart-lang/sdk/commit/5e4a3d7a655b478fa9f32f357d453c2df716c0e1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger.h View 1 chunk +0 lines, -1 line 2 comments Download
M runtime/vm/isolate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/longjump.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/thread.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/thread_registry.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 1 month ago (2015-10-26 18:37:38 UTC) #2
srdjan
LGTMwC https://chromiumcodereview.appspot.com/1408923005/diff/1/runtime/vm/debugger.h File runtime/vm/debugger.h (left): https://chromiumcodereview.appspot.com/1408923005/diff/1/runtime/vm/debugger.h#oldcode654 runtime/vm/debugger.h:654: ASSERT(isolate_->MutatorThreadIsCurrentThread()); Why did you remove this assert? We ...
5 years, 1 month ago (2015-10-26 19:21:41 UTC) #3
siva
https://chromiumcodereview.appspot.com/1408923005/diff/1/runtime/vm/debugger.h File runtime/vm/debugger.h (left): https://chromiumcodereview.appspot.com/1408923005/diff/1/runtime/vm/debugger.h#oldcode654 runtime/vm/debugger.h:654: ASSERT(isolate_->MutatorThreadIsCurrentThread()); On 2015/10/26 19:21:41, srdjan wrote: > Why did ...
5 years, 1 month ago (2015-10-26 19:56:21 UTC) #4
siva
5 years, 1 month ago (2015-10-26 20:12:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5e4a3d7a655b478fa9f32f357d453c2df716c0e1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698