runtime/vm/thread_registry.cc - Issue 1408923005: Add IsMutatorThread to the Thread class and use it instead of MutatorThreadIsCurrentThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread_registry.cc

Issue 1408923005: Add IsMutatorThread to the Thread class and use it instead of MutatorThreadIsCurrentThread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/thread_registry.cc

diff --git a/runtime/vm/thread_registry.cc b/runtime/vm/thread_registry.cc

index ee21ec9ec73eca2c2b35411abb8fcc54b6fe7283..f0f80e3fd08cab01d2c82715410765c1953df4aa 100644

--- a/runtime/vm/thread_registry.cc

+++ b/runtime/vm/thread_registry.cc

@@ -33,7 +33,7 @@ void ThreadRegistry::SafepointThreads() {

// TODO(koda): Rename Thread::PrepareForGC and call it here?

--remaining_; // Exclude this thread from the count.

// Ensure the main mutator will reach a safepoint (could be running Dart).

- if (!isolate->MutatorThreadIsCurrentThread()) {

+ if (!Thread::Current()->IsMutatorThread()) {

isolate->ScheduleInterrupts(Isolate::kVMInterrupt);

}

while (remaining_ > 0) {

« runtime/vm/debugger.h ('K') | « runtime/vm/thread.cc ('k') | no next file » | no next file with comments »