Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1408923003: Revert of path ops: fix conic weight and partial coincidence (Closed)

Created:
5 years, 2 months ago by caryclark
Modified:
5 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of path ops: fix conic weight and partial coincidence (patchset #5 id:80001 of https://codereview.chromium.org/1413763002/ ) Reason for revert: path ops change breaks svg clipping layout tests -- conic is now more accurate, changing edge of circle in clip These need to be rebaselined svg/clip-path/clip-path-child-clipped.svg svg/clip-path/clip-path-nonzero.svg svg/clip-path/clip-path-evenodd-nonzero.svg svg/clip-path/clip-path-nonzero-evenodd.svg Original issue's description: > The remaining 1m skp bugs are asserts that can be harmlessly > suppressed and bugs around conics. > > The conic calculation for a subdivided w was just wrong. > > Also added debugging to template intersection to initialize > reused structures and dump additional data. > > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/ef33b1e739b23a1201100ff17a572da85b03d9af TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/f428df1be3e96d3f8970d0f7f415b862f7da5404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -824 lines) Patch
M src/pathops/SkOpCoincidence.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsConic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsConic.cpp View 2 chunks +6 lines, -28 lines 0 comments Download
M src/pathops/SkPathOpsCubic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M src/pathops/SkPathOpsQuad.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsRect.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 9 chunks +11 lines, -61 lines 0 comments Download
M src/pathops/SkPathOpsWinding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSkpTest.cpp View 2 chunks +3 lines, -661 lines 0 comments Download
M tests/PathOpsTSectDebug.h View 2 chunks +6 lines, -16 lines 0 comments Download
M tools/pathops_sorter.htm View 1 chunk +4 lines, -19 lines 0 comments Download
M tools/pathops_visualizer.htm View 11 chunks +89 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
caryclark
Created Revert of path ops: fix conic weight and partial coincidence
5 years, 2 months ago (2015-10-21 11:02:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408923003/1
5 years, 2 months ago (2015-10-21 11:02:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/f428df1be3e96d3f8970d0f7f415b862f7da5404
5 years, 2 months ago (2015-10-21 11:02:59 UTC) #3
caryclark
5 years, 2 months ago (2015-10-22 14:23:36 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1407003016/ by caryclark@google.com.

The reason for reverting is: suppressions have landed in chrome.

Powered by Google App Engine
This is Rietveld 408576698