Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1408813002: Remove crypto::ECPrivateKey::IsSupported. (Closed)

Created:
5 years, 2 months ago by davidben
Modified:
5 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove crypto::ECPrivateKey::IsSupported. We no longer need to worry about the system NSS on decrepit Linux distributions. The only platform where ECPrivateKey is backed by NSS is iOS and we control that one. BUG=519504 Committed: https://crrev.com/24bb5a4b2e4d909c27740c5a12b3e167c49329f2 Cr-Commit-Position: refs/heads/master@{#354379}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -73 lines) Patch
M crypto/ec_private_key.h View 1 chunk +0 lines, -3 lines 0 comments Download
M crypto/ec_private_key_nss.cc View 4 chunks +2 lines, -36 lines 0 comments Download
M crypto/ec_private_key_openssl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket.h View 1 chunk +3 lines, -5 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 3 chunks +2 lines, -9 lines 1 comment Download
M net/socket/ssl_client_socket_nss.cc View 2 chunks +7 lines, -15 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
5 years, 2 months ago (2015-10-15 20:17:43 UTC) #2
Ryan Sleevi
LGTM, although we may have to end up re-introducing some of this code if Token ...
5 years, 2 months ago (2015-10-15 22:00:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408813002/1
5 years, 2 months ago (2015-10-15 22:05:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 22:13:30 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 22:14:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24bb5a4b2e4d909c27740c5a12b3e167c49329f2
Cr-Commit-Position: refs/heads/master@{#354379}

Powered by Google App Engine
This is Rietveld 408576698