relnote: Measure HOL blocking in QUIC headers stream. Flag protected by quic_measure_headers_hol_bl…

relnote: Measure HOL blocking in QUIC headers stream. Flag protected by quic_measure_headers_hol_blocking_time, default enabled.

Adds new UMA histogram: Net.QuicSession.HeadersHOLBlockedTime

Merge internal change: 104894802

R=rch@chromium.org
BUG=

Committed: https://crrev.com/99850b3757a2dbff4ae4eba8111b5e1417ef5ea2
Cr-Commit-Position: refs/heads/master@{#354598}

[Ryan Hamilton, 2015-10-15 21:48:06]

https://codereview.chromium.org/1408803002/diff/1/net/quic/quic_headers_strea...
File net/quic/quic_headers_stream_test.cc (right):

https://codereview.chromium.org/1408803002/diff/1/net/quic/quic_headers_strea...
net/quic/quic_headers_stream_test.cc:352: #if 0
What's the story with the #if 0s?

[Buck, 2015-10-15 21:51:51]

On 2015/10/15 21:48:06, Ryan Hamilton wrote:
>
https://codereview.chromium.org/1408803002/diff/1/net/quic/quic_headers_strea...
> File net/quic/quic_headers_stream_test.cc (right):
> 
>
https://codereview.chromium.org/1408803002/diff/1/net/quic/quic_headers_strea...
> net/quic/quic_headers_stream_test.cc:352: #if 0
> What's the story with the #if 0s?

The internal CL tests the log messages using utilities that are not present on
the chromium side.  I noticed prior instances of this elsewhere in the chromium
net code that use #if 0, so I went with it also.

[Ryan Hamilton, 2015-10-16 17:43:53]

lgtm

https://codereview.chromium.org/1408803002/diff/1/net/quic/quic_headers_strea...
File net/quic/quic_headers_stream_test.cc (right):

https://codereview.chromium.org/1408803002/diff/1/net/quic/quic_headers_strea...
net/quic/quic_headers_stream_test.cc:406: #endif
I'm somewhat surprised that nesting #ifndef/#endif inside #if/#endif actually
works! I hate C :>

[Buck, 2015-10-16 17:49:12]

The CQ bit was checked by ckrasic@chromium.org

[commit-bot: I haz the power, 2015-10-16 17:49:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408803002/1

[commit-bot: I haz the power, 2015-10-16 17:55:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 17:55:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Buck, 2015-10-16 18:02:56]

ckrasic@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Buck, 2015-10-16 18:03:23]

+r asvitkine for histograms.xml

[Alexei Svitkine (slow), 2015-10-16 18:32:26]

lgtm

[Buck, 2015-10-16 18:32:46]

The CQ bit was checked by ckrasic@chromium.org

[Buck, 2015-10-16 18:32:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1408803002/#ps20001
(title: "update reviewers")

[commit-bot: I haz the power, 2015-10-16 18:34:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408803002/20001

[commit-bot: I haz the power, 2015-10-16 18:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 18:36:59]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Buck, 2015-10-16 20:48:28]

The CQ bit was checked by ckrasic@chromium.org

[Buck, 2015-10-16 20:48:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1408803002/#ps60001
(title: "get rid of git certs leakage")

[commit-bot: I haz the power, 2015-10-16 20:49:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408803002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408803002/60001

[commit-bot: I haz the power, 2015-10-16 21:16:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-16 21:17:48]

Patchset 4 (id:??) landed as
https://crrev.com/99850b3757a2dbff4ae4eba8111b5e1417ef5ea2
Cr-Commit-Position: refs/heads/master@{#354598}