Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1400293002: relnote: refactoring the buffering logic in QUIC's stream sequencer. (Closed)

Created:
5 years, 2 months ago by Buck
Modified:
5 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, ramant_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: refactoring the buffering logic in QUIC's stream sequencer. Add a wrapper class QuicFrameList for underlying buffered_frames_ list in QuicStreamSequencer to prepare for future changes of data structure for buffered_frames_. It shares the same interface with its substitution StreamSequencerBuffer. Merge internal change: 104518889 R=rch@chromium.org BUG= Committed: https://crrev.com/f160a6ead8049f80e7f63cdf939ba01f436b75f5 Cr-Commit-Position: refs/heads/master@{#354361}

Patch Set 1 #

Patch Set 2 : Fix build issue with quic_frame_list.* #

Patch Set 3 : fix license on new files #

Patch Set 4 : Merge internal change: 104894802 #

Patch Set 5 : fix c++11 initializer issue in quic_headers_stream_test.cc #

Patch Set 6 : std::initializer_list!! gah! #

Patch Set 7 : disentangle merge of 104894802 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -204 lines) Patch
M net/net.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A net/quic/quic_frame_list.h View 1 2 4 5 6 1 chunk +99 lines, -0 lines 0 comments Download
A net/quic/quic_frame_list.cc View 1 2 4 5 6 1 chunk +198 lines, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer.h View 4 5 6 4 chunks +2 lines, -29 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 4 5 6 6 chunks +33 lines, -170 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_peer.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Buck
5 years, 2 months ago (2015-10-14 00:03:25 UTC) #1
Ryan Hamilton
lgtm
5 years, 2 months ago (2015-10-15 13:45:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400293002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400293002/120001
5 years, 2 months ago (2015-10-15 21:16:58 UTC) #5
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 2 months ago (2015-10-15 21:28:09 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 21:29:01 UTC) #7
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/f160a6ead8049f80e7f63cdf939ba01f436b75f5
Cr-Commit-Position: refs/heads/master@{#354361}

Powered by Google App Engine
This is Rietveld 408576698