Fix GN unittests on windows broken by abs-path change

Fix GN unittests on windows broken by abs-path change

Mixed up gen_dir and out_dir in one win-only unit test in a recent CL,
https://codereview.chromium.org/1420973003

R=brettw@chromium.org, andybons@chromium.org
BUG=

Committed: https://crrev.com/784ffb68d74d58986d58aaa88e33573608f548ee
Cr-Commit-Position: refs/heads/master@{#356945}

[tsniatowski, 2015-10-29 18:29:35]

PTAL. As much as I believe this to be correct, could you test it on a Windows
machine, Andrew? I don't have one handy.

BTW -- shouldn't this be caught by the queue back when
https://codereview.chromium.org/1420973003 landed?

[Bons, 2015-10-29 18:38:27]

On 2015/10/29 18:29:35, tsniatowski wrote:
> PTAL. As much as I believe this to be correct, could you test it on a Windows
> machine, Andrew? I don't have one handy.
> 
> BTW -- shouldn't this be caught by the queue back when
> https://codereview.chromium.org/1420973003 landed?

No. The CQ doesn't run gn_unittests. It should, though ;)

[Bons, 2015-10-29 18:39:11]

andybons@chromium.org changed reviewers:
+ dpranke@chromium.org

[Bons, 2015-10-29 18:39:11]

Adding dpranke since I’m not in OWNERS and Brett is in Asia.

[Bons, 2015-10-29 18:51:57]

The CQ bit was checked by andybons@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 18:53:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408793007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408793007/1

[tsniatowski, 2015-10-29 19:02:42]

On 2015/10/29 18:38:27, Bons wrote:
> On 2015/10/29 18:29:35, tsniatowski wrote:
> > PTAL. As much as I believe this to be correct, could you test it on a
Windows
> > machine, Andrew? I don't have one handy.
> > 
> > BTW -- shouldn't this be caught by the queue back when
> > https://codereview.chromium.org/1420973003 landed?
> 
> No. The CQ doesn't run gn_unittests. It should, though ;)

Who do I poke to make that happen? ;) Should I file a crbug?

[Bons, 2015-10-29 19:03:26]

File a bug and paste it here
On Thu, Oct 29, 2015 at 3:02 PM <tsniatowski@opera.com> wrote:

> On 2015/10/29 18:38:27, Bons wrote:
> > On 2015/10/29 18:29:35, tsniatowski wrote:
> > > PTAL. As much as I believe this to be correct, could you test it on a
> Windows
> > > machine, Andrew? I don't have one handy.
> > >
> > > BTW -- shouldn't this be caught by the queue back when
> > > https://codereview.chromium.org/1420973003 landed?
>
> > No. The CQ doesn't run gn_unittests. It should, though ;)
>
> Who do I poke to make that happen? ;) Should I file a crbug?
>
> https://codereview.chromium.org/1408793007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tsniatowski, 2015-10-29 19:13:12]

On 2015/10/29 19:03:26, Bons wrote:
> File a bug and paste it here
> On Thu, Oct 29, 2015 at 3:02 PM <mailto:tsniatowski@opera.com> wrote:
> 

Filed https://code.google.com/p/chromium/issues/detail?id=549254

[commit-bot: I haz the power, 2015-10-29 19:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 19:15:45]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-10-29 20:56:51]

lgtm

[tsniatowski, 2015-10-29 20:57:51]

The CQ bit was checked by tsniatowski@opera.com

[commit-bot: I haz the power, 2015-10-29 20:59:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408793007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408793007/1

[commit-bot: I haz the power, 2015-10-29 21:09:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-29 21:10:54]

Patchset 1 (id:??) landed as
https://crrev.com/784ffb68d74d58986d58aaa88e33573608f548ee
Cr-Commit-Position: refs/heads/master@{#356945}