Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1420973003: Make sure abs-path gn labels have separate target_gen_dirs (Closed)

Created:
5 years, 2 months ago by tsniatowski
Modified:
5 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure abs-path gn labels have separate target_gen_dirs Use gen/ABS_PATH/... for target_gen_dir of build files outside of the source tree, to mimic obj/ABS_PATH that's used for object directories for such build files. Previously, all build files outside of the source tree would use root_gen_dir (e.g. out/Default/gen) as target_gen_dir. This broke the "target_gen_dir is unique between different BUILD.gn files" assumption, causing strange behavior and "ninja: multiple targets generate ..." warnings for users of absolute path BUILD.gn files outside of //. BUG=445454 R=brettw@chromium.org Committed: https://crrev.com/5b6813c06deae18ca309fba9913ee18e28150122 Cr-Commit-Position: refs/heads/master@{#356011}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -24 lines) Patch
M tools/gn/filesystem_utils.cc View 1 3 chunks +31 lines, -21 lines 0 comments Download
M tools/gn/function_get_path_info_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/gn/substitution_writer_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tsniatowski
PTAL
5 years, 2 months ago (2015-10-23 20:06:31 UTC) #1
brettw
lgtm https://codereview.chromium.org/1420973003/diff/1/tools/gn/filesystem_utils.cc File tools/gn/filesystem_utils.cc (right): https://codereview.chromium.org/1420973003/diff/1/tools/gn/filesystem_utils.cc#newcode689 tools/gn/filesystem_utils.cc:689: void AppendFixedAbsolutePathSuffix(const BuildSettings *build_settings, Nit: * next to ...
5 years, 1 month ago (2015-10-26 00:36:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420973003/20001
5 years, 1 month ago (2015-10-26 06:21:45 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 06:32:26 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 06:33:02 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b6813c06deae18ca309fba9913ee18e28150122
Cr-Commit-Position: refs/heads/master@{#356011}

Powered by Google App Engine
This is Rietveld 408576698