DescriptionMake sure abs-path gn labels have separate target_gen_dirs
Use gen/ABS_PATH/... for target_gen_dir of build files outside of the
source tree, to mimic obj/ABS_PATH that's used for object directories
for such build files.
Previously, all build files outside of the source tree would use
root_gen_dir (e.g. out/Default/gen) as target_gen_dir. This broke the
"target_gen_dir is unique between different BUILD.gn files" assumption,
causing strange behavior and "ninja: multiple targets generate ..."
warnings for users of absolute path BUILD.gn files outside of //.
BUG=445454
R=brettw@chromium.org
Committed: https://crrev.com/5b6813c06deae18ca309fba9913ee18e28150122
Cr-Commit-Position: refs/heads/master@{#356011}
Patch Set 1 #
Total comments: 1
Patch Set 2 : #
Messages
Total messages: 7 (2 generated)
|