Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: chrome/browser/about_flags.h

Issue 1408783002: Support base::Feature entries in chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/feature_list.cc ('k') | chrome/browser/about_flags.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.h
diff --git a/chrome/browser/about_flags.h b/chrome/browser/about_flags.h
index b2336ccc97bc04d9f1ae16938b6a769173c5c355..dcc1d57345ff5ffa699eccb83bbcbe86426f5806 100644
--- a/chrome/browser/about_flags.h
+++ b/chrome/browser/about_flags.h
@@ -56,6 +56,11 @@ struct FeatureEntry {
// if the feature should be on when not explicitly specified via about
// flags - for example via FieldTrials.
ENABLE_DISABLE_VALUE,
+
+ // Corresponds to a base::Feature, per base/feature_list.h. The entry will
+ // have three states: Default, Enabled, Disabled. When not specified or set
+ // to Default, the normal default value of the feature is used.
+ FEATURE_VALUE,
};
// Used for MULTI_VALUE types to describe one of the possible values the user
@@ -101,6 +106,9 @@ struct FeatureEntry {
const char* disable_command_line_switch;
const char* disable_command_line_value;
+ // For FEATURE_VALUE, the name of the base::Feature this entry corresponds to.
+ const char* feature_name;
+
// This is used if type is MULTI_VALUE.
const Choice* choices;
« no previous file with comments | « base/feature_list.cc ('k') | chrome/browser/about_flags.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698