Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2103)

Unified Diff: base/feature_list.cc

Issue 1408783002: Support base::Feature entries in chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/feature_list.h ('k') | chrome/browser/about_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/feature_list.cc
diff --git a/base/feature_list.cc b/base/feature_list.cc
index 2acd2900dca1e1a85d725b02556d24d99816a584..38cdf57c139ff5812ae3063e6e5e74f140750322 100644
--- a/base/feature_list.cc
+++ b/base/feature_list.cc
@@ -20,11 +20,6 @@ namespace {
// have more control over initialization timing. Leaky.
FeatureList* g_instance = nullptr;
-// Splits a comma-separated string containing feature names into a vector.
-std::vector<std::string> SplitFeatureListString(const std::string& input) {
- return SplitString(input, ",", TRIM_WHITESPACE, SPLIT_WANT_NONEMPTY);
-}
-
} // namespace
FeatureList::FeatureList() : initialized_(false) {}
@@ -94,6 +89,12 @@ bool FeatureList::IsEnabled(const Feature& feature) {
}
// static
+std::vector<std::string> FeatureList::SplitFeatureListString(
+ const std::string& input) {
+ return SplitString(input, ",", TRIM_WHITESPACE, SPLIT_WANT_NONEMPTY);
+}
+
+// static
FeatureList* FeatureList::GetInstance() {
return g_instance;
}
« no previous file with comments | « base/feature_list.h ('k') | chrome/browser/about_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698