MD Settings: Factor out some pref manipulation into the PrefsBehavior.

MD Settings: Factor out some pref manipulation into the PrefsBehavior.

BUG=425627
Committed: https://crrev.com/ac85fc2969f2c11c78aad8c3911123c05d831197
Cr-Commit-Position: refs/heads/master@{#363305}

[michaelpg, 2015-11-04 03:58:00]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org

[michaelpg, 2015-11-04 03:58:00]

PTAL. Open to better naming suggestions.

[Dan Beam, 2015-11-04 04:24:41]

arguably this would be a ListPrefsBehavior that depends on PrefsBehavior

but i suppose we can do that if it matters for some performance reason.

the only real benefit right now would be less cognitive load when looking at the
code / less properties and mixing in when we bring more PrefsBehavior clients
online.

[Dan Beam, 2015-11-04 04:24:46]

lgtm

[michaelpg, 2015-11-04 04:29:12]

Yeah, that's not a bad idea. And the next logical step would be a
DictionaryPrefsBehavior which also depended on PrefsBehavior. But then you
get the dependency questions we haven't tackled yet.
On Nov 3, 2015 8:24 PM, <dbeam@chromium.org> wrote:

> arguably this would be a ListPrefsBehavior that depends on PrefsBehavior
>
> but i suppose we can do that if it matters for some performance reason.
>
> the only real benefit right now would be less cognitive load when looking
> at the
> code / less properties and mixing in when we bring more PrefsBehavior
> clients
> online.
>
> https://codereview.chromium.org/1408753005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[michaelpg, 2015-11-21 23:05:14]

Description was changed from

==========
MD Settings: Factor out some pref manipulation into the PrefsBehavior.

BUG=425627
==========

to

==========
MD Settings: Factor out some pref manipulation into the PrefsBehavior.

Closed to create PrefUtil instead.

BUG=425627
==========

[michaelpg, 2015-11-22 04:09:09]

Description was changed from

==========
MD Settings: Factor out some pref manipulation into the PrefsBehavior.

Closed to create PrefUtil instead.

BUG=425627
==========

to

==========
MD Settings: Factor out some pref manipulation into the PrefsBehavior.

BUG=425627
==========

[michaelpg, 2015-12-04 21:03:02]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2015-12-04 21:03:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1408753005/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-12-04 21:05:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408753005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408753005/20001

[commit-bot: I haz the power, 2015-12-04 22:07:10]

Description was changed from

==========
MD Settings: Factor out some pref manipulation into the PrefsBehavior.

BUG=425627
==========

to

==========
MD Settings: Factor out some pref manipulation into the PrefsBehavior.

BUG=425627
==========

[commit-bot: I haz the power, 2015-12-04 22:07:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-04 22:08:10]

Description was changed from

==========
MD Settings: Factor out some pref manipulation into the PrefsBehavior.

BUG=425627
==========

to

==========
MD Settings: Factor out some pref manipulation into the PrefsBehavior.

BUG=425627

Committed: https://crrev.com/ac85fc2969f2c11c78aad8c3911123c05d831197
Cr-Commit-Position: refs/heads/master@{#363305}
==========

[commit-bot: I haz the power, 2015-12-04 22:08:11]

Patchset 2 (id:??) landed as
https://crrev.com/ac85fc2969f2c11c78aad8c3911123c05d831197
Cr-Commit-Position: refs/heads/master@{#363305}