Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4168)

Unified Diff: chrome/browser/resources/settings/languages_page/languages.js

Issue 1408753005: MD Settings: Factor out some pref manipulation into the PrefsBehavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@LanguagePage6LanguageHelper
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/prefs/prefs_behavior.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/languages_page/languages.js
diff --git a/chrome/browser/resources/settings/languages_page/languages.js b/chrome/browser/resources/settings/languages_page/languages.js
index fb15e44b0c08497eea698e38a5e5a8c7e112d90c..a8925429cd2bdd12055c5a6e82cf330b2ebf4af7 100644
--- a/chrome/browser/resources/settings/languages_page/languages.js
+++ b/chrome/browser/resources/settings/languages_page/languages.js
@@ -347,7 +347,7 @@ SettingsLanguagesSingletonElement = Polymer({
assert(this.canDisableLanguage(languageCode));
// Remove the language from spell check.
- this.arrayDelete('prefs.spellcheck.dictionaries.value', languageCode);
+ this.deletePrefListItem('spellcheck.dictionaries', languageCode);
// Remove the language from preferred languages.
var languageCodes =
@@ -385,7 +385,7 @@ SettingsLanguagesSingletonElement = Polymer({
*/
enableTranslateLanguage: function(languageCode) {
languageCode = this.convertLanguageCodeForTranslate(languageCode);
- this.arrayDelete('prefs.translate_blocked_languages.value', languageCode);
+ this.deletePrefListItem('translate_blocked_languages', languageCode);
},
/**
@@ -394,11 +394,8 @@ SettingsLanguagesSingletonElement = Polymer({
* @param {string} languageCode
*/
disableTranslateLanguage: function(languageCode) {
- languageCode = this.convertLanguageCodeForTranslate(languageCode);
- if (this.getPref('translate_blocked_languages').value
- .indexOf(languageCode) == -1) {
- this.push('prefs.translate_blocked_languages.value', languageCode);
- }
+ this.appendPrefListItem('translate_blocked_languages',
+ this.convertLanguageCodeForTranslate(languageCode));
},
/**
@@ -412,10 +409,9 @@ SettingsLanguagesSingletonElement = Polymer({
if (enable) {
var spellCheckPref = this.getPref('spellcheck.dictionaries');
- if (spellCheckPref.value.indexOf(languageCode) == -1)
- this.push('prefs.spellcheck.dictionaries.value', languageCode);
+ this.appendPrefListItem('spellcheck.dictionaries', languageCode);
} else {
- this.arrayDelete('prefs.spellcheck.dictionaries.value', languageCode);
+ this.deletePrefListItem('spellcheck.dictionaries', languageCode);
}
},
« no previous file with comments | « no previous file | chrome/browser/resources/settings/prefs/prefs_behavior.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698