Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1408743005: Properly recreate swapped out RenderView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: A different approach. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index 3a40ad73e5bc87f71b23a73a81dff4d788ad1f4c..2cdeaf15186d5afbff51fab56b8ae1fa218ff35b 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -670,12 +670,12 @@ class CONTENT_EXPORT RenderFrameHostManager {
int bindings);
// Sets up the necessary state for a new RenderViewHost. Creates a
- // RenderFrameProxy in the target renderer process with the given
- // |proxy_routing_id|, which is used to route IPC messages when in swapped
+ // RenderFrameProxy in the target renderer process with the given valid
Charlie Reis 2015/10/16 23:09:57 This comment makes it sound like the proxy is requ
nasko 2015/10/16 23:42:09 Done.
+ // |proxy|, which is used to route IPC messages when in swapped
// out state. Returns early if the RenderViewHost has already been
// initialized for another RenderFrameHost.
bool InitRenderView(RenderViewHostImpl* render_view_host,
- int proxy_routing_id);
+ RenderFrameProxyHost* proxy);
// Initialization for RenderFrameHost uses the same sequence as InitRenderView
// above.

Powered by Google App Engine
This is Rietveld 408576698