Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1408743005: Properly recreate swapped out RenderView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: A different approach. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 10
(...skipping 652 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 // PlzNavigate 663 // PlzNavigate
664 // Creates and initializes a speculative RenderFrameHost and/or WebUI for an 664 // Creates and initializes a speculative RenderFrameHost and/or WebUI for an
665 // ongoing navigation. They might be destroyed and re-created later if the 665 // ongoing navigation. They might be destroyed and re-created later if the
666 // navigation is redirected to a different SiteInstance. 666 // navigation is redirected to a different SiteInstance.
667 bool CreateSpeculativeRenderFrameHost(const GURL& url, 667 bool CreateSpeculativeRenderFrameHost(const GURL& url,
668 SiteInstance* old_instance, 668 SiteInstance* old_instance,
669 SiteInstance* new_instance, 669 SiteInstance* new_instance,
670 int bindings); 670 int bindings);
671 671
672 // Sets up the necessary state for a new RenderViewHost. Creates a 672 // Sets up the necessary state for a new RenderViewHost. Creates a
673 // RenderFrameProxy in the target renderer process with the given 673 // RenderFrameProxy in the target renderer process with the given valid
Charlie Reis 2015/10/16 23:09:57 This comment makes it sound like the proxy is requ
nasko 2015/10/16 23:42:09 Done.
674 // |proxy_routing_id|, which is used to route IPC messages when in swapped 674 // |proxy|, which is used to route IPC messages when in swapped
675 // out state. Returns early if the RenderViewHost has already been 675 // out state. Returns early if the RenderViewHost has already been
676 // initialized for another RenderFrameHost. 676 // initialized for another RenderFrameHost.
677 bool InitRenderView(RenderViewHostImpl* render_view_host, 677 bool InitRenderView(RenderViewHostImpl* render_view_host,
678 int proxy_routing_id); 678 RenderFrameProxyHost* proxy);
679 679
680 // Initialization for RenderFrameHost uses the same sequence as InitRenderView 680 // Initialization for RenderFrameHost uses the same sequence as InitRenderView
681 // above. 681 // above.
682 bool InitRenderFrame(RenderFrameHostImpl* render_frame_host); 682 bool InitRenderFrame(RenderFrameHostImpl* render_frame_host);
683 683
684 // Sets the pending RenderFrameHost/WebUI to be the active one. Note that this 684 // Sets the pending RenderFrameHost/WebUI to be the active one. Note that this
685 // doesn't require the pending render_frame_host_ pointer to be non-NULL, 685 // doesn't require the pending render_frame_host_ pointer to be non-NULL,
686 // since there could be Web UI switching as well. Call this for every commit. 686 // since there could be Web UI switching as well. Call this for every commit.
687 // If PlzNavigate is enabled the method will set the speculative (not pending) 687 // If PlzNavigate is enabled the method will set the speculative (not pending)
688 // RenderFrameHost to be the active one. 688 // RenderFrameHost to be the active one.
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 bool should_reuse_web_ui_; 828 bool should_reuse_web_ui_;
829 829
830 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_; 830 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_;
831 831
832 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager); 832 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager);
833 }; 833 };
834 834
835 } // namespace content 835 } // namespace content
836 836
837 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 837 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698