Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/heap_test.cc

Issue 1408653002: Skip making code pages temporarily writable when finalizing the VM isolate loaded from precompiled … (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/heap.h ('K') | « runtime/vm/heap.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap_test.cc
diff --git a/runtime/vm/heap_test.cc b/runtime/vm/heap_test.cc
index e609901f8c5e8a10a6f2f9d0a81c65a66318e6b2..f52a81cdf73eeebe8448a79682ca823787ebf1be 100644
--- a/runtime/vm/heap_test.cc
+++ b/runtime/vm/heap_test.cc
@@ -280,9 +280,9 @@ TEST_CASE(IterateReadOnly) {
const String& obj = String::Handle(String::New("x", Heap::kOld));
Heap* heap = Thread::Current()->isolate()->heap();
EXPECT(heap->Contains(RawObject::ToAddr(obj.raw())));
- heap->WriteProtect(true);
+ heap->WriteProtect(true, true /* include_code_pages */);
EXPECT(heap->Contains(RawObject::ToAddr(obj.raw())));
- heap->WriteProtect(false);
+ heap->WriteProtect(false, true /* include_code_pages */);
EXPECT(heap->Contains(RawObject::ToAddr(obj.raw())));
}
« runtime/vm/heap.h ('K') | « runtime/vm/heap.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698