Skip making code pages temporarily writable when finalizing the VM isolate loaded from precompiled …

runtime/vm/heap.h

Index: runtime/vm/heap.h
diff --git a/runtime/vm/heap.h b/runtime/vm/heap.h
index 22a109ecfece5909be36e3ea415148d391a1ae6d..d8fd903d18ba7aaf8ceb1f431a0d3d1fa3ed47ba 100644
--- a/runtime/vm/heap.h
+++ b/runtime/vm/heap.h
@@ -136,7 +136,7 @@ class Heap {
 
   // Protect access to the heap. Note: Code pages are made
   // executable/non-executable when 'read_only' is true/false, respectively.
-  void WriteProtect(bool read_only);
+  void WriteProtect(bool read_only, bool include_code_pages);
   void WriteProtectCode(bool read_only) {
     old_space_.WriteProtectCode(read_only);
   }
@@ -377,8 +377,11 @@ class NoHeapGrowthControlScope : public StackResource {
 // Note: During this scope, the code pages are non-executable.
 class WritableVMIsolateScope : StackResource {
  public:
-  explicit WritableVMIsolateScope(Thread* thread);
+  explicit WritableVMIsolateScope(Thread* thread, bool include_code_pages);

[siva, 2015/10/15 01:01:29]

not explicit anymore as it has two parameters?

   ~WritableVMIsolateScope();
+
+ private:
+  bool include_code_pages_;
 };
 
 }  // namespace dart