Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: components/sync_sessions/sync_sessions_client.h

Issue 1408643002: [Sync] Componentize synced_tab_delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GN, self review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_sessions/sync_sessions_client.h
diff --git a/components/sync_sessions/sync_sessions_client.h b/components/sync_sessions/sync_sessions_client.h
new file mode 100644
index 0000000000000000000000000000000000000000..d86b4ef87d82c9f75ea30eb2997fbac5d3528b10
--- /dev/null
+++ b/components/sync_sessions/sync_sessions_client.h
@@ -0,0 +1,38 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_SYNC_SESSIONS_SYNC_SESSIONS_CLIENT_H_
+#define COMPONENTS_SYNC_SESSIONS_SYNC_SESSIONS_CLIENT_H_
+
+class GURL;
+
+namespace browser_sync {
+class SyncedTabDelegate;
skym 2015/10/16 16:55:47 Are these forward declarations in preparation for
Nicolas Zea 2015/10/20 23:14:42 Woops, these were leftovers from previous iteratio
+}
+
+namespace sessions {
+struct SessionTab;
skym 2015/10/16 16:55:47 Same.
Nicolas Zea 2015/10/20 23:14:42 Done.
+struct SessionWindow;
+}
+
+namespace sync_sessions {
+
+// Interface for clients of a sync sessions datatype. Should be used as a getter
+// for services and data the Sync Sessions datatype depends on.
+class SyncSessionsClient {
+ public:
+ SyncSessionsClient();
+ virtual ~SyncSessionsClient();
+
+ // Checks if the given url is considered interesting enough to sync. Most urls
+ // are considered interesting. Examples of ones that are not are invalid urls,
+ // files, and chrome internal pages.
+ // TODO(zea): make this a standalone function if the url constants are
+ // componentized.
+ virtual bool ShouldSyncURL(const GURL& url) const = 0;
+};
+
+} // namespace sync_sessions
+
+#endif // COMPONENTS_SYNC_SESSIONS_SYNC_SESSIONS_CLIENT_H_

Powered by Google App Engine
This is Rietveld 408576698