Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: components/sync_sessions/sync_sessions_client.h

Issue 1408643002: [Sync] Componentize synced_tab_delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GN, self review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_SYNC_SESSIONS_SYNC_SESSIONS_CLIENT_H_
6 #define COMPONENTS_SYNC_SESSIONS_SYNC_SESSIONS_CLIENT_H_
7
8 class GURL;
9
10 namespace browser_sync {
11 class SyncedTabDelegate;
skym 2015/10/16 16:55:47 Are these forward declarations in preparation for
Nicolas Zea 2015/10/20 23:14:42 Woops, these were leftovers from previous iteratio
12 }
13
14 namespace sessions {
15 struct SessionTab;
skym 2015/10/16 16:55:47 Same.
Nicolas Zea 2015/10/20 23:14:42 Done.
16 struct SessionWindow;
17 }
18
19 namespace sync_sessions {
20
21 // Interface for clients of a sync sessions datatype. Should be used as a getter
22 // for services and data the Sync Sessions datatype depends on.
23 class SyncSessionsClient {
24 public:
25 SyncSessionsClient();
26 virtual ~SyncSessionsClient();
27
28 // Checks if the given url is considered interesting enough to sync. Most urls
29 // are considered interesting. Examples of ones that are not are invalid urls,
30 // files, and chrome internal pages.
31 // TODO(zea): make this a standalone function if the url constants are
32 // componentized.
33 virtual bool ShouldSyncURL(const GURL& url) const = 0;
34 };
35
36 } // namespace sync_sessions
37
38 #endif // COMPONENTS_SYNC_SESSIONS_SYNC_SESSIONS_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698