chrome/browser/sync/test/integration/sessions_helper.cc - Issue 1408643002: [Sync] Componentize synced_tab_delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/sessions_helper.cc

Issue 1408643002: [Sync] Componentize synced_tab_delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN, self review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/test/integration/sessions_helper.cc

diff --git a/chrome/browser/sync/test/integration/sessions_helper.cc b/chrome/browser/sync/test/integration/sessions_helper.cc

index d69baa20641d2642caa442f1adb7c9daf8be6317..e6c61e6e889b96705d4ef28e3389c20bd1d99e76 100644

--- a/chrome/browser/sync/test/integration/sessions_helper.cc

+++ b/chrome/browser/sync/test/integration/sessions_helper.cc

@@ -139,12 +139,13 @@ class TabEventHandler : public browser_sync::LocalSessionEventHandler {

TestTimeouts::action_max_timeout());

}

- void OnLocalTabModified(

+ bool OnLocalTabModified(

browser_sync::SyncedTabDelegate* modified_tab) override {

// Unwind to ensure SessionsSyncManager has processed the event.

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(&TabEventHandler::QuitLoop, weak_factory_.GetWeakPtr()));

+ return true;

}

void OnFaviconsChanged(const std::set<GURL>& /* page_urls */,