Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 153063002: plumbing for skia trace events into Chrome's about://tracing framework (Closed)

Created:
6 years, 10 months ago by humper
Modified:
6 years, 10 months ago
Reviewers:
piman, nduca, bsalomon, reed1
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

plumbing for skia trace events into Chrome's about://tracing framework BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249128

Patch Set 1 #

Total comments: 6

Patch Set 2 : File reorg, move initialization to render_thread_impl #

Total comments: 1

Patch Set 3 : add OVERRIDE macros #

Patch Set 4 : Explicitly mark the init function as SK_API for dll export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M content/renderer/render_thread_impl.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
A skia/ext/event_tracer_impl.h View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A skia/ext/event_tracer_impl.cc View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
M skia/skia_chrome.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M skia/skia_library.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
humper
PTAL; I've tested this with some local hacks to third_party/skia and it appears to work.
6 years, 10 months ago (2014-02-03 19:58:58 UTC) #1
humper
+reed, +bsalomon for owners in skia/ext
6 years, 10 months ago (2014-02-03 20:05:31 UTC) #2
bsalomon
lgtm Aside: Maybe is RendererMain a place where we could stick a call to SkGraphics:Init()?
6 years, 10 months ago (2014-02-03 21:44:29 UTC) #3
piman
https://codereview.chromium.org/153063002/diff/1/content/renderer/renderer_main.cc File content/renderer/renderer_main.cc (right): https://codereview.chromium.org/153063002/diff/1/content/renderer/renderer_main.cc#newcode244 content/renderer/renderer_main.cc:244: SkEventTracer::SetInstance(new skia::SkChromiumEventTracer()); nit: should we do this in the ...
6 years, 10 months ago (2014-02-03 22:25:02 UTC) #4
nduca
https://codereview.chromium.org/153063002/diff/1/content/renderer/renderer_main.cc File content/renderer/renderer_main.cc (right): https://codereview.chromium.org/153063002/diff/1/content/renderer/renderer_main.cc#newcode244 content/renderer/renderer_main.cc:244: SkEventTracer::SetInstance(new skia::SkChromiumEventTracer()); yea definitely reder thread impl https://codereview.chromium.org/153063002/diff/1/skia/ext/trace_event.h File ...
6 years, 10 months ago (2014-02-04 01:15:19 UTC) #5
humper
https://codereview.chromium.org/153063002/diff/1/content/renderer/renderer_main.cc File content/renderer/renderer_main.cc (right): https://codereview.chromium.org/153063002/diff/1/content/renderer/renderer_main.cc#newcode244 content/renderer/renderer_main.cc:244: SkEventTracer::SetInstance(new skia::SkChromiumEventTracer()); On 2014/02/03 22:25:02, piman wrote: > nit: ...
6 years, 10 months ago (2014-02-04 19:58:07 UTC) #6
nduca
https://codereview.chromium.org/153063002/diff/100001/skia/ext/event_tracer_impl.cc File skia/ext/event_tracer_impl.cc (right): https://codereview.chromium.org/153063002/diff/100001/skia/ext/event_tracer_impl.cc#newcode75 skia/ext/event_tracer_impl.cc:75: // Initialize the binding to Skia's tracing events. Skia ...
6 years, 10 months ago (2014-02-04 20:01:37 UTC) #7
humper
On 2014/02/04 20:01:37, nduca wrote: > https://codereview.chromium.org/153063002/diff/100001/skia/ext/event_tracer_impl.cc > File skia/ext/event_tracer_impl.cc (right): > > https://codereview.chromium.org/153063002/diff/100001/skia/ext/event_tracer_impl.cc#newcode75 > ...
6 years, 10 months ago (2014-02-04 20:20:25 UTC) #8
piman
LGTM for content/
6 years, 10 months ago (2014-02-04 21:40:28 UTC) #9
humper
The CQ bit was checked by humper@google.com
6 years, 10 months ago (2014-02-04 21:41:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/humper@google.com/153063002/100001
6 years, 10 months ago (2014-02-04 22:36:11 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 23:51:40 UTC) #12
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=112338
6 years, 10 months ago (2014-02-04 23:51:40 UTC) #13
humper
The CQ bit was checked by humper@google.com
6 years, 10 months ago (2014-02-05 17:25:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/humper@google.com/153063002/410001
6 years, 10 months ago (2014-02-05 17:29:30 UTC) #15
humper
The CQ bit was checked by humper@google.com
6 years, 10 months ago (2014-02-05 19:04:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/humper@google.com/153063002/720001
6 years, 10 months ago (2014-02-05 19:11:48 UTC) #17
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 21:59:24 UTC) #18
Message was sent while issue was closed.
Change committed as 249128

Powered by Google App Engine
This is Rietveld 408576698