Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1408543003: Webapps splashscreen: hide the splashscreen if the renderer process crashes. (Closed)

Created:
5 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Webapps splashscreen: hide the splashscreen if the renderer process crashes. Instead of showing a splashscreen for ever, the user will then be able to see the sad face and reload the page eventually. Tests will be part of https://codereview.chromium.org/1405023002 BUG=543604 Committed: https://crrev.com/037cbdff2c4f1cbf3e32bc256bdfeed5b434067f Cr-Commit-Position: refs/heads/master@{#354804}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 1 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (2 generated)
mlamouri (slow - plz ping)
5 years, 2 months ago (2015-10-15 16:34:08 UTC) #2
gone
+dtrainor for input
5 years, 2 months ago (2015-10-15 20:15:57 UTC) #3
mlamouri (slow - plz ping)
-dtrainor@ Dan, PTAL. I moved the tests out of this CL, making it less controversial ...
5 years, 2 months ago (2015-10-17 12:33:19 UTC) #4
gone
lgtm
5 years, 2 months ago (2015-10-19 17:26:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408543003/20001
5 years, 2 months ago (2015-10-19 17:35:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-19 18:22:19 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 18:23:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/037cbdff2c4f1cbf3e32bc256bdfeed5b434067f
Cr-Commit-Position: refs/heads/master@{#354804}

Powered by Google App Engine
This is Rietveld 408576698