Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1405413002: Webapps splashscreen: hide the splashscreen after the page has fully loaded. (Closed)

Created:
5 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@splashscreen-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Webapps splashscreen: hide the splashscreen after the page has fully loaded. There are situations where the WebContents isn't notified of a first visually non empty paint. In these rare situations, the splashscreen will stay visible forever. As a safety net, the splashscreen will be hidden when the page is fully loaded. At that point, there should have been a first paint or it will happen at the very next layout. The tests will be added as part of https://codereview.chromium.org/1405023002 BUG=531519, 542626 Committed: https://crrev.com/8efe0f049baac8abec82ef22b0a522fbf8da5e43 Cr-Commit-Position: refs/heads/master@{#354681}

Patch Set 1 #

Patch Set 2 : rebase + no tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 1 2 chunks +28 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
mlamouri (slow - plz ping)
5 years, 2 months ago (2015-10-16 15:25:09 UTC) #2
gone
l-g-t-m. Still waiting on Dave's comments, though.
5 years, 2 months ago (2015-10-16 17:03:22 UTC) #3
gone
lgtm if you break out the fix for the beta branch; no need to gate ...
5 years, 2 months ago (2015-10-16 17:10:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405413002/20001
5 years, 2 months ago (2015-10-17 12:22:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-17 12:52:43 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-17 12:53:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8efe0f049baac8abec82ef22b0a522fbf8da5e43
Cr-Commit-Position: refs/heads/master@{#354681}

Powered by Google App Engine
This is Rietveld 408576698