Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 140853005: update custom elements and shadow dom (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 29b2825fe0c3c63eaadad5398cc8177616502a3e..f966796cd656f9c85671bcaa6fa5377e1ca38308 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -7813,7 +7813,7 @@ class Document extends Node native "Document"
/// Checks if [register] is supported on the current platform.
bool get supportsRegister {
- return JS('bool', '("register" in #)', this);
+ return JS('bool', '("registerElement" in #)', this);
}
@DomName('Document.createElement')
@@ -35161,7 +35161,7 @@ void _registerCustomElement(context, document, String tag, Type type,
// }
// }
// });
- // document.register('x-foo', { prototype: proto });
+ // document.registerElement('x-foo', { prototype: proto });
// ...
// var e = document.createElement('x-foo');
@@ -35205,9 +35205,9 @@ void _registerCustomElement(context, document, String tag, Type type,
JS('void', '#.createdCallback = #', properties,
JS('=Object', '{value: #}',
_makeCallbackMethod(_callConstructor(constructor, interceptor))));
- JS('void', '#.enteredViewCallback = #', properties,
+ JS('void', '#.attachedCallback = #', properties,
JS('=Object', '{value: #}', _makeCallbackMethod(_callEnteredView)));
- JS('void', '#.leftViewCallback = #', properties,
+ JS('void', '#.detachedCallback = #', properties,
JS('=Object', '{value: #}', _makeCallbackMethod(_callLeftView)));
JS('void', '#.attributeChangedCallback = #', properties,
JS('=Object', '{value: #}', _makeCallbackMethod3(_callAttributeChanged)));
@@ -35223,7 +35223,7 @@ void _registerCustomElement(context, document, String tag, Type type,
JS('=Object', '#.extends = #', options, extendsTagName);
}
- JS('void', '#.register(#, #)', document, tag, options);
+ JS('void', '#.registerElement(#, #)', document, tag, options);
}
//// Called by Element.created to do validation & initialization.

Powered by Google App Engine
This is Rietveld 408576698