Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tools/dom/src/dart2js_CustomElementSupport.dart

Issue 140853005: update custom elements and shadow dom (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/src/dart2js_CustomElementSupport.dart
diff --git a/tools/dom/src/dart2js_CustomElementSupport.dart b/tools/dom/src/dart2js_CustomElementSupport.dart
index 665cd5e26e61f0529f0948a28241932b37325d68..b6221907be44bc2f7d480e2f2cb6f769854e458d 100644
--- a/tools/dom/src/dart2js_CustomElementSupport.dart
+++ b/tools/dom/src/dart2js_CustomElementSupport.dart
@@ -55,7 +55,7 @@ void _registerCustomElement(context, document, String tag, Type type,
// }
// }
// });
- // document.register('x-foo', { prototype: proto });
+ // document.registerElement('x-foo', { prototype: proto });
// ...
// var e = document.createElement('x-foo');
@@ -99,9 +99,9 @@ void _registerCustomElement(context, document, String tag, Type type,
JS('void', '#.createdCallback = #', properties,
JS('=Object', '{value: #}',
_makeCallbackMethod(_callConstructor(constructor, interceptor))));
- JS('void', '#.enteredViewCallback = #', properties,
+ JS('void', '#.attachedCallback = #', properties,
blois 2014/01/28 00:15:27 Can keep both enteredView and attachedCallback unt
Jennifer Messerly 2014/01/29 20:52:37 chatted in person, I think with registerElement we
JS('=Object', '{value: #}', _makeCallbackMethod(_callEnteredView)));
- JS('void', '#.leftViewCallback = #', properties,
+ JS('void', '#.detachedCallback = #', properties,
JS('=Object', '{value: #}', _makeCallbackMethod(_callLeftView)));
JS('void', '#.attributeChangedCallback = #', properties,
JS('=Object', '{value: #}', _makeCallbackMethod3(_callAttributeChanged)));
@@ -117,7 +117,7 @@ void _registerCustomElement(context, document, String tag, Type type,
JS('=Object', '#.extends = #', options, extendsTagName);
}
- JS('void', '#.register(#, #)', document, tag, options);
+ JS('void', '#.registerElement(#, #)', document, tag, options);
}
//// Called by Element.created to do validation & initialization.

Powered by Google App Engine
This is Rietveld 408576698