chrome/test/data/password/ambiguous_password_form.html - Issue 1408423003: [Password Manager] Ignore autofilling invisible password fields.

Side by Side Diff: chrome/test/data/password/ambiguous_password_form.html

Issue 1408423003: [Password Manager] Ignore autofilling invisible password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added more handling. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/test/data/password/password_form.html » ('j') | chrome/test/data/password/password_form.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!-- Password form with the username and password fields having ambiguity in id attribute. -->	2 <!-- Password form with the username and password fields having ambiguity in id attribute. -->

3 <form id='ambiguous_form' method='POST' action='done.html'>	3 <form id='ambiguous_form' method='POST' action='done.html'>

4 <label>Username: </label><input type='text' id='ambiguous_id' />	4 <label>Username: </label><input type='text' id='ambiguous_id' />

5 <label>Password: </label><input type='password' id='ambiguous_id' />	5 <label>Password: </label><input type='password' id='ambiguous_id' />

6 <input type='submit' />	6 <input type='submit' />

7 </form>	7 </form>

8	8

9 <!-- Password form having username and password fields without name and id attri bute. -->	9 <!-- Password form having username and password fields without name and id attri bute. -->

10 <form id='no_name_id_form' method='POST' action='done.html'>	10 <form id='no_name_id_form' method='POST' action='done.html'>

(...skipping 18 matching lines...) Expand all Loading...
29 <input type='submit' />	29 <input type='submit' />

30 </form>	30 </form>

31	31

32 <!-- Change password form having username and password fields with empty names b ut no \|autocomplete='xxx'\| attributes. -->	32 <!-- Change password form having username and password fields with empty names b ut no \|autocomplete='xxx'\| attributes. -->

33 <form id='change_pwd_but_no_autocomplete' method='POST' action='done.html'>	33 <form id='change_pwd_but_no_autocomplete' method='POST' action='done.html'>

34 <label>Username: </label> <input type='text' placeholder='username' />	34 <label>Username: </label> <input type='text' placeholder='username' />

35 <label>Old Password: </label> <input type='password' placeholder='Old Password ' />	35 <label>Old Password: </label> <input type='password' placeholder='Old Password ' />

36 <label>New Password: </label> <input type='password' placeholder='New password ' />	36 <label>New Password: </label> <input type='password' placeholder='New password ' />

37 <input type='submit' />	37 <input type='submit' />

38 </form>	38 </form>

	39

	40 <!-- Ambiguous password form with problematic invisible password field. -->

	41 <form id='hidden_password_form' method='POST' action='done.html'>

	42 <input type='password' placeholder='Password' style="display:none;" autocomple te="off" />

	43 <label>Username: </label><input type='text' placeholder='Username' />
	vabr (Chromium) 2015/10/20 16:40:22 Could you put the hidden password field between us Could you put the hidden password field between username and password? That would make sure that Chrome does not work just because of first looking for the username and then for the immediately following password. Pritam Nikam 2015/10/22 09:00:08 Done. Show quoted text On 2015/10/20 16:40:22, vabr (Chromium) wrote: > Could you put the hidden password field between username and password? That > would make sure that Chrome does not work just because of first looking for the > username and then for the immediately following password. Done.
	44 <label>Password: </label><input type='password' placeholder='Password' />

	45 <input type='submit' />

	46 </form>

OLD	NEW