Parse -webkit-border shorthands in CSSPropertyParser with CSSParserTokens

Parse -webkit-border shorthands in CSSPropertyParser with CSSParserTokens

Move -webkit-border shorthands property handling from LegacyCSSPropertyParser
into CSSPropertyParser. Also move the related longhands.

BUG=499780
Committed: https://crrev.com/d3b1904c8c7d2d89f8ce5228c1478f1321a6c87a
Cr-Commit-Position: refs/heads/master@{#358911}

[rwlbuis, 2015-11-09 03:29:41]

Description was changed from

==========
WebkitBorder WIP


Rebase

BUG=
==========

to

==========
Parse webkit-border shorthands in CSSPropertyParser with CSSParserTokens

Move webkit-border shorthands property handling from
LegacyCSSPropertyParser into CSSPropertyParser. Also
move its related longhands.

BUG=499780
==========

[rwlbuis, 2015-11-09 03:30:29]

Description was changed from

==========
Parse webkit-border shorthands in CSSPropertyParser with CSSParserTokens

Move webkit-border shorthands property handling from
LegacyCSSPropertyParser into CSSPropertyParser. Also
move its related longhands.

BUG=499780
==========

to

==========
Parse -webkit-border shorthands in CSSPropertyParser with CSSParserTokens

Move -webkit-border shorthands property handling from
LegacyCSSPropertyParser into CSSPropertyParser. Also
move the related longhands.

BUG=499780
==========

[rwlbuis, 2015-11-09 03:31:05]

Description was changed from

==========
Parse -webkit-border shorthands in CSSPropertyParser with CSSParserTokens

Move -webkit-border shorthands property handling from
LegacyCSSPropertyParser into CSSPropertyParser. Also
move the related longhands.

BUG=499780
==========

to

==========
Parse -webkit-border shorthands in CSSPropertyParser with CSSParserTokens

Move -webkit-border shorthands property handling from LegacyCSSPropertyParser
into CSSPropertyParser. Also move the related longhands.

BUG=499780
==========

[rwlbuis, 2015-11-09 03:32:40]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-11-09 03:32:41]

PTAL.

[Timothy Loh, 2015-11-09 16:51:50]

On 2015/11/09 03:32:41, rwlbuis wrote:
> PTAL.

Shouldn't we use consumeLineWidth like
https://codereview.chromium.org/1407203004/ and just put the case statements
next to each other?

[rwlbuis, 2015-11-09 17:05:54]

On 2015/11/09 16:51:50, Timothy Loh wrote:
> On 2015/11/09 03:32:41, rwlbuis wrote:
> > PTAL.
> 
> Shouldn't we use consumeLineWidth like
> https://codereview.chromium.org/1407203004/ and just put the case statements
> next to each other?

Yes, but consumeLineWidth is not in AFAIK :) I'll make a new patch once it is
in, and also group the cases statements.

[rwlbuis, 2015-11-09 19:16:43]

On 2015/11/09 17:05:54, rwlbuis wrote:
> On 2015/11/09 16:51:50, Timothy Loh wrote:
> > On 2015/11/09 03:32:41, rwlbuis wrote:
> > > PTAL.
> > 
> > Shouldn't we use consumeLineWidth like
> > https://codereview.chromium.org/1407203004/ and just put the case statements
> > next to each other?
> 
> Yes, but consumeLineWidth is not in AFAIK :) I'll make a new patch once it is
> in, and also group the cases statements.

Done!

[Timothy Loh, 2015-11-10 19:29:35]

On 2015/11/09 19:16:43, rwlbuis wrote:
> On 2015/11/09 17:05:54, rwlbuis wrote:
> > On 2015/11/09 16:51:50, Timothy Loh wrote:
> > > On 2015/11/09 03:32:41, rwlbuis wrote:
> > > > PTAL.
> > > 
> > > Shouldn't we use consumeLineWidth like
> > > https://codereview.chromium.org/1407203004/ and just put the case
statements
> > > next to each other?
> > 
> > Yes, but consumeLineWidth is not in AFAIK :) I'll make a new patch once it
is
> > in, and also group the cases statements.
> 
> Done!

lgtm

[rwlbuis, 2015-11-10 19:50:19]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-11-10 19:51:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408383010/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408383010/40001

[commit-bot: I haz the power, 2015-11-10 21:43:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-10 21:44:48]

Patchset 3 (id:??) landed as
https://crrev.com/d3b1904c8c7d2d89f8ce5228c1478f1321a6c87a
Cr-Commit-Position: refs/heads/master@{#358911}