Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1408383010: Parse -webkit-border shorthands in CSSPropertyParser with CSSParserTokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reuse consumeLineWidth Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
index 3b39657fcb01990bf6001f9085f8e95a87b5a2f4..eae576e89c50cee8cd40bc98a5d18b2e98f80fad 100644
--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
@@ -424,10 +424,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyBorderRightColor:
case CSSPropertyBorderBottomColor:
case CSSPropertyBorderLeftColor:
- case CSSPropertyWebkitBorderStartColor:
- case CSSPropertyWebkitBorderEndColor:
- case CSSPropertyWebkitBorderBeforeColor:
- case CSSPropertyWebkitBorderAfterColor:
case CSSPropertyWebkitColumnRuleColor:
case CSSPropertyWebkitTextStrokeColor:
parsedValue = parseColor(m_valueList->current(), acceptQuirkyColors(propId));
@@ -599,10 +595,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
unitless = FUnitlessQuirk;
// fall through
case CSSPropertyWebkitTextStrokeWidth:
- case CSSPropertyWebkitBorderStartWidth:
- case CSSPropertyWebkitBorderEndWidth:
- case CSSPropertyWebkitBorderBeforeWidth:
- case CSSPropertyWebkitBorderAfterWidth:
case CSSPropertyWebkitColumnRuleWidth:
if (id == CSSValueThin || id == CSSValueMedium || id == CSSValueThick)
validPrimitive = true;
@@ -1001,14 +993,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyBorderLeft:
// [ 'border-left-width' || 'border-style' || <color> ] | inherit
return parseShorthand(propId, borderLeftShorthand(), important);
- case CSSPropertyWebkitBorderStart:
- return parseShorthand(propId, webkitBorderStartShorthand(), important);
- case CSSPropertyWebkitBorderEnd:
- return parseShorthand(propId, webkitBorderEndShorthand(), important);
- case CSSPropertyWebkitBorderBefore:
- return parseShorthand(propId, webkitBorderBeforeShorthand(), important);
- case CSSPropertyWebkitBorderAfter:
- return parseShorthand(propId, webkitBorderAfterShorthand(), important);
case CSSPropertyBorderColor:
// <color>{1,4} | inherit
return parse4Values(propId, borderColorShorthand().properties(), important);
@@ -1177,6 +1161,18 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyOutlineColor:
case CSSPropertyOutlineWidth:
case CSSPropertyOutlineOffset:
+ case CSSPropertyWebkitBorderStartColor:
+ case CSSPropertyWebkitBorderEndColor:
+ case CSSPropertyWebkitBorderBeforeColor:
+ case CSSPropertyWebkitBorderAfterColor:
+ case CSSPropertyWebkitBorderStartWidth:
+ case CSSPropertyWebkitBorderEndWidth:
+ case CSSPropertyWebkitBorderBeforeWidth:
+ case CSSPropertyWebkitBorderAfterWidth:
+ case CSSPropertyWebkitBorderStart:
+ case CSSPropertyWebkitBorderEnd:
+ case CSSPropertyWebkitBorderBefore:
+ case CSSPropertyWebkitBorderAfter:
validPrimitive = false;
break;
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698