Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1408343007: QUIC - Delete Net.QuicClientHelloRejectReasons.Insecure histogram. (Closed)

Created:
5 years, 1 month ago by ramant (doing other things)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Delete Net.QuicClientHelloRejectReasons.Insecure histogram. It was deleted in the following CL: https://codereview.chromium.org/1411063004/diff/300001/net/quic/crypto/quic_crypto_client_config.cc R=asvitkine@chromium.org, rch@chromium.org BUG=549278 Committed: https://crrev.com/47a801065f6e46e3dc2be4913c5cfcb9ff116e07 Cr-Commit-Position: refs/heads/master@{#356973}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 1 chunk +5 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (1 generated)
ramant (doing other things)
5 years, 1 month ago (2015-10-29 20:28:54 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/1408343007/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1408343007/diff/1/tools/metrics/histograms/histograms.xml#oldcode77698 tools/metrics/histograms/histograms.xml:77698: - <suffix name="Insecure" label="for insecure QUIC."/> Just mark this ...
5 years, 1 month ago (2015-10-29 20:30:04 UTC) #2
ramant (doing other things)
https://codereview.chromium.org/1408343007/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1408343007/diff/1/tools/metrics/histograms/histograms.xml#oldcode77698 tools/metrics/histograms/histograms.xml:77698: - <suffix name="Insecure" label="for insecure QUIC."/> On 2015/10/29 20:30:04, ...
5 years, 1 month ago (2015-10-29 20:45:45 UTC) #3
Alexei Svitkine (slow)
lgtm
5 years, 1 month ago (2015-10-29 20:53:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408343007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408343007/20001
5 years, 1 month ago (2015-10-29 20:57:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 22:58:22 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 22:59:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47a801065f6e46e3dc2be4913c5cfcb9ff116e07
Cr-Commit-Position: refs/heads/master@{#356973}

Powered by Google App Engine
This is Rietveld 408576698