media/base/audio_converter.cc - Issue 14083011: CHECK for adding duplicate converter inputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/audio_converter.cc

Issue 14083011: CHECK for adding duplicate converter inputs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/audio_converter.cc

diff --git a/media/base/audio_converter.cc b/media/base/audio_converter.cc

index ec74e038a3bc7f4ded3073095fb259d451ec8237..f970a94c0b654b01c6612dcbe0c8568394a026e0 100644

--- a/media/base/audio_converter.cc

+++ b/media/base/audio_converter.cc

@@ -88,6 +88,8 @@ AudioConverter::AudioConverter(const AudioParameters& input_params,

AudioConverter::~AudioConverter() {}

void AudioConverter::AddInput(InputCallback* input) {

+ CHECK(std::find(transform_inputs_.begin(), transform_inputs_.end(), input) ==

scherkus (not reviewing) 2013/04/24 22:06:42 if this is a speculative CHECK() can you add TODO

DaleCurtis 2013/04/24 22:13:59 Done.

+ transform_inputs_.end());

transform_inputs_.push_back(input);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »