CHECK for adding duplicate converter inputs.

media/base/audio_converter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/audio_converter.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 70 matching lines @@
             input_params.channels(),
         input_params.frames_per_buffer(), base::Bind(
             &AudioConverter::SourceCallback,
             base::Unretained(this))));
   }
 }
 
 AudioConverter::~AudioConverter() {}
 
 void AudioConverter::AddInput(InputCallback* input) {
+  CHECK(std::find(transform_inputs_.begin(), transform_inputs_.end(), input) ==

[scherkus (not reviewing), 2013/04/24 22:06:42]

if this is a speculative CHECK() can you add TODO + reference bug?

[DaleCurtis, 2013/04/24 22:13:59]

Done.

+        transform_inputs_.end());
   transform_inputs_.push_back(input);
 }
 
 void AudioConverter::RemoveInput(InputCallback* input) {
   DCHECK(std::find(transform_inputs_.begin(), transform_inputs_.end(), input) !=
          transform_inputs_.end());
   transform_inputs_.remove(input);
 
   if (transform_inputs_.empty())
     Reset();
@@ skipping 109 matching lines @@
 
 void AudioConverter::ProvideInput(int resampler_frame_delay, AudioBus* dest) {
   resampler_frame_delay_ = resampler_frame_delay;
   if (audio_fifo_)
     audio_fifo_->Consume(dest, dest->frames());
   else
     SourceCallback(0, dest);
 }
 
 }  // namespace media