Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1408193002: [blimp] Simplify Blimp buildbot setup. (Closed)

Created:
5 years, 2 months ago by nyquist
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, David Trainor- moved to gerrit
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[blimp] Simplify Blimp buildbot setup. This CL changes it so that only the minimal configuration needed is used on the buildbots for blimp. Unit test targets need to be specified on the test bots they run, which leads to the target being compiled on the respective builder bot (there are builder/tester pairs specified in recipes). Since the blimp_unittests target depends on //blimp:blimp, there is no need for us to manually specify that target anywhere. The Android GN (dbg) is special in that it currently has no devices attached, so it is unable to run any tests. After this CL, the following builders/testers will run and test the following targets: - Android GN: compile (blimp_unittests) + test (blimp_unittests) - Android GN (dbg): compile (blimp_tests) - Linux Builder: compile (blimp_unittests) - Linux Tests: test (blimp_unittests) - Linux Builder (dbg): compile (blimp_unittests) - Linux Tests (dbg)(1): test (blimp_unittests) BUG=543267 Committed: https://crrev.com/cbaea342d88ce93c5986b8719cb18d08907eb336 Cr-Commit-Position: refs/heads/master@{#354618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M testing/buildbot/chromium.linux.json View 5 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nyquist
dpranke: PTAL The goal of my CL is thoroughly specified in the CL description, so ...
5 years, 2 months ago (2015-10-16 19:19:33 UTC) #2
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-16 19:34:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408193002/1
5 years, 2 months ago (2015-10-16 20:27:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/121891)
5 years, 2 months ago (2015-10-16 21:25:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408193002/1
5 years, 2 months ago (2015-10-16 21:34:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 22:10:47 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 22:12:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbaea342d88ce93c5986b8719cb18d08907eb336
Cr-Commit-Position: refs/heads/master@{#354618}

Powered by Google App Engine
This is Rietveld 408576698