Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1408183007: [turbofan] Setup frames as needed. (Closed)

Created:
5 years, 1 month ago by Mircea Trofin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Setup frames as needed. We used to mark a block as needing frame based solely on the spill list. With splintering, that is not entirely accurate. With this change, for ranges that spill only in deferred blocks, we mark the start of each block in which a child range spills as needing a frame. BUG=v8:4533 LOG=n Committed: https://crrev.com/796c30eade2fc784ab22f08d52f9f7b431335e7f Cr-Commit-Position: refs/heads/master@{#31769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M src/compiler/register-allocator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 3 chunks +27 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408183007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408183007/1
5 years, 1 month ago (2015-11-02 21:17:04 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 1 month ago (2015-11-02 21:17:06 UTC) #4
Benedikt Meurer
LGTM.
5 years, 1 month ago (2015-11-03 05:37:09 UTC) #8
Benedikt Meurer
Please create tracking bugs for changes like these (I created one for this and updated ...
5 years, 1 month ago (2015-11-03 05:37:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408183007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408183007/1
5 years, 1 month ago (2015-11-04 06:47:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 07:05:21 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 07:05:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/796c30eade2fc784ab22f08d52f9f7b431335e7f
Cr-Commit-Position: refs/heads/master@{#31769}

Powered by Google App Engine
This is Rietveld 408576698