Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 1408183004: Minor cleanup as saved_isolate_ should always be NULL in this case per the ASSERT in the constructo… (Closed)

Created:
5 years, 1 month ago by siva
Modified:
5 years, 1 month ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Minor cleanup as saved_isolate_ should always be NULL in this case per the ASSERT in the constructor. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/baaee47bd87efa2d1ff0e295de49b1aed8eabfaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M runtime/vm/isolate.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
5 years, 1 month ago (2015-10-28 22:14:37 UTC) #2
siva
+John
5 years, 1 month ago (2015-10-29 20:04:59 UTC) #4
Cutch
lgtm
5 years, 1 month ago (2015-10-29 20:27:46 UTC) #5
siva
5 years, 1 month ago (2015-10-29 21:36:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
baaee47bd87efa2d1ff0e295de49b1aed8eabfaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698