runtime/vm/isolate.h - Issue 1408183004: Minor cleanup as saved_isolate_ should always be NULL in this case per the ASSERT in the constructo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.h

Issue 1408183004: Minor cleanup as saved_isolate_ should always be NULL in this case per the ASSERT in the constructo… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/isolate.h

diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h

index 908e64171e16736a7d3ffc659865359589f4cf6c..fab7049dd5b798b1ddf05c1491160a106603efd1 100644

--- a/runtime/vm/isolate.h

+++ b/runtime/vm/isolate.h

@@ -912,9 +912,7 @@ class StartIsolateScope {

if (saved_isolate_ != new_isolate_) {

new_isolate_->ClearStackLimit();

Thread::ExitIsolate();

- if (saved_isolate_ != NULL) {

- Thread::EnterIsolate(saved_isolate_);

- }

+ ASSERT(saved_isolate_ == NULL);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »