util/file/file_io_win.cc - Issue 1408123006: Tidy up to enable C4800 on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/file/file_io_win.cc

Issue 1408123006: Tidy up to enable C4800 on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/file/file_io_win.cc

diff --git a/util/file/file_io_win.cc b/util/file/file_io_win.cc

index 10805439f6a616806bb5fb29bdc4cb9e95c2bdc3..def2a5a2bf8d5592e3cda1ad5b5cce12c4d09d90 100644

--- a/util/file/file_io_win.cc

+++ b/util/file/file_io_win.cc

@@ -233,7 +233,7 @@ bool LoggingTruncateFile(FileHandle file) {

bool LoggingCloseFile(FileHandle file) {

BOOL rv = CloseHandle(file);

PLOG_IF(ERROR, !rv) << "CloseHandle";

- return rv;

+ return !!rv;

}

} // namespace crashpad

« no previous file with comments | « snapshot/win/system_snapshot_win.cc ('k') | util/win/critical_section_with_debug_info.cc » ('j') | no next file with comments »