Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: util/file/file_io_win.cc

Issue 1408123006: Tidy up to enable C4800 on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« client/settings.cc ('K') | « snapshot/win/system_snapshot_win.cc ('k') | util/win/critical_section_with_debug_info.cc » ('j') | util/win/critical_section_with_debug_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/file/file_io_win.cc
diff --git a/util/file/file_io_win.cc b/util/file/file_io_win.cc
index 10805439f6a616806bb5fb29bdc4cb9e95c2bdc3..def2a5a2bf8d5592e3cda1ad5b5cce12c4d09d90 100644
--- a/util/file/file_io_win.cc
+++ b/util/file/file_io_win.cc
@@ -233,7 +233,7 @@ bool LoggingTruncateFile(FileHandle file) {
bool LoggingCloseFile(FileHandle file) {
BOOL rv = CloseHandle(file);
PLOG_IF(ERROR, !rv) << "CloseHandle";
- return rv;
+ return !!rv;
}
} // namespace crashpad
« client/settings.cc ('K') | « snapshot/win/system_snapshot_win.cc ('k') | util/win/critical_section_with_debug_info.cc » ('j') | util/win/critical_section_with_debug_info.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698