client/crashpad_client_win.cc - Issue 1408123006: Tidy up to enable C4800 on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/crashpad_client_win.cc

Issue 1408123006: Tidy up to enable C4800 on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/crashpad_client_win.cc

diff --git a/client/crashpad_client_win.cc b/client/crashpad_client_win.cc

index 3b3eaa6a6051329fe1f428ab135464492569d827..92529ae18989c002ccb9f507294003daf6799509 100644

--- a/client/crashpad_client_win.cc

+++ b/client/crashpad_client_win.cc

@@ -229,7 +229,7 @@ void CrashpadClient::DumpWithoutCrash(const CONTEXT& context) {

g_non_crash_exception_information.exception_pointers =

reinterpret_cast<crashpad::WinVMAddress>(&exception_pointers);

- bool set_event_result = SetEvent(g_signal_non_crash_dump);

+ bool set_event_result = !!SetEvent(g_signal_non_crash_dump);

Mark Mentovai 2015/10/22 21:22:40 Ugly, but well, at least it’s not !!::.

PLOG_IF(ERROR, !set_event_result) << "SetEvent";

DWORD wfso_result = WaitForSingleObject(g_non_crash_dump_done, INFINITE);