|
Identity API: Change WebAuthFlow to use <webview> instead of a normal browser pop-up.
All Identity API UI is moving into a webview tag inside a component app, allowing Chrome Apps
to be isolated from the browser.
The launchWebAuthFlow API is affected by this change. The getAuthToken API will be updated
to use WebAuthFlow instead of native dialogs in a separate change.
The WebAuthFlow unit tests have been deleted. They weren't providing anything that isn't
covered in the browser tests for launchWebAuthFlow.
Two features of the (experimental) API have been removed. The chrome-extension: is not supported
in webviews. HTTPS must be used instead. Explicit control over the size of the dialog is no
longer supported.
BUG= 228908
(This is step #6 in the description.)
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+593 lines, -404 lines) |
Patch |
 |
M |
chrome/browser/browser_resources.grd
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/identity/experimental_identity_api.h
|
View
|
1
|
3 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/identity/experimental_identity_api.cc
|
View
|
1
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/extensions/api/identity/experimental_web_auth_flow.h
|
View
|
1
|
6 chunks |
+17 lines, -16 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/extensions/api/identity/experimental_web_auth_flow.cc
|
View
|
1
|
8 chunks |
+15 lines, -15 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/extensions/api/identity/experimental_web_auth_flow_unittest.cc
|
View
|
1
|
10 chunks |
+40 lines, -36 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/identity/identity_api.h
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/identity/identity_api.cc
|
View
|
1
|
5 chunks |
+12 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/identity/identity_apitest.cc
|
View
|
1
|
6 chunks |
+78 lines, -19 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/identity/web_auth_flow.h
|
View
|
|
6 chunks |
+49 lines, -18 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/identity/web_auth_flow.cc
|
View
|
|
4 chunks |
+157 lines, -66 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -184 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/extensions/api/identity_private/identity_private_api.h
|
View
|
1
|
1 chunk |
+14 lines, -15 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/extensions/api/identity_private/identity_private_api.cc
|
View
|
1
|
1 chunk |
+33 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/component_loader.cc
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/extension_function_histogram_value.h
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/resources/component_extension_resources.grd
|
View
|
1
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/resources/identity_api_ui/identity_api_ui.css
|
View
|
1
|
1 chunk |
+23 lines, -13 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/resources/identity_api_ui/identity_api_ui.js
|
View
|
|
1 chunk |
+26 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/resources/identity_api_ui/manifest.json
|
View
|
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/resources/identity_api_ui/scope_approval_dialog.html
|
View
|
|
1 chunk |
+13 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/resources/identity_api_ui/scope_approval_dialog.js
|
View
|
1
|
1 chunk |
+31 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_extensions.gypi
|
View
|
1
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests_unit.gypi
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/api/_permission_features.json
|
View
|
1
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/api/api.gyp
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/common/extensions/api/identity_private.idl
|
View
|
1
|
1 chunk |
+20 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/extension_constants.h
|
View
|
1
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/extension_constants.cc
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/permissions/api_permission.h
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/permissions/chrome_api_permissions.cc
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
chrome/test/data/extensions/api_test/identity/interaction_required.html
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
chrome/test/data/extensions/api_test/identity/redirect_to_chromiumapp.html
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A |
chrome/test/data/extensions/api_test/identity/redirect_to_chromiumapp.html.mock-http-headers
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|